ci(docs): remove stale broken-links quarantine superseded by #164#167
Merged
Conversation
PR #166 added continue-on-error to the Docs Validation broken-links step as a quarantine for the 9 missing scim.mdx image links, merged concurrently with #164 which fixed the actual broken links (removed the dead <Frame><img> references, added the missing docs.json nav entry). With the root cause fixed, the quarantine is dead weight that would silently mask any *new* broken link in docs/** going forward. Verified: `cd docs && npx mintlify broken-links` still passes without continue-on-error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: true) for 9 missingenterprise/setting-up-entra/scim.mdximage links, merged concurrently with fix: docs-validation broken links + helm-release fork guard #164, which fixed the actual broken links at the source (removed the dead<Frame><img>blocks, added the missingdocs.jsonnav entry).docs/**going forward, since the whole step iscontinue-on-error.continue-on-errorline and itsfork-patches.txtentry so full broken-link coverage applies again.Test plan
cd docs && npx mintlify broken-links→success no broken links found(verified without the quarantine)mainafter merge (push-only workflow, not runnable on the PR itself)Generated by Claude Code