fix(ci): un-quarantine 3 tests confirmed passing on upstream/main#169
Merged
Merged
Conversation
TestSQLite_Customer_HashMismatch_FileSync, TestSQLite_Governance_FullReconciliation, and TestOCRWithMockServer were skipped due to upstream breakage. Re-verified against a clean upstream/main worktree today and all three now pass, so remove them from the GOTEST_SKIP quarantine lists to restore full test coverage on those paths. The other quarantined tests (TestConfigSchemaSync, TestSkillsServingGenericFileDownloadDecodesEncodedPathParams, TestTranscriptionStreamContextCancellation, TestTranscriptionWithMockServer, TestMistralProvider_CustomAliasChatStreamUsesBaseCompatibilityAndAliasMetadata) still fail/race on upstream/main and remain quarantined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily maintenance re-check of the fork's quarantined-test removal conditions found that 3 of the 8 currently-quarantined tests now pass on a clean
upstream/mainworktree. Removes them from theGOTEST_SKIPlists inrelease-pipeline.ymlto restore full test coverage.Changes
.github/workflows/release-pipeline.yml: removedTestSQLite_Customer_HashMismatch_FileSyncandTestSQLite_Governance_FullReconciliationfrom thetest-bifrost-httpGOTEST_SKIP; removedTestOCRWithMockServerfrom thetest-coreGOTEST_SKIP..github/fork-patches.txt: updated the corresponding quarantine entries to reflect the reduced skip lists and record when/why each test was un-quarantined.Verified via an isolated
git worktree add /tmp/up-check upstream/main(removed afterward, no changes to this repo's history):TestSQLite_Customer_HashMismatch_FileSync— PASSESTestSQLite_Governance_FullReconciliation— PASSESTestOCRWithMockServer— PASSES (all 6 subtests)The remaining quarantined tests were re-verified as still broken on upstream and are left in place:
TestConfigSchemaSync— real schema drift (circuit_breaker_config/governance.rolesmissing)TestSkillsServingGenericFileDownloadDecodesEncodedPathParams— data race (fasthttpShutdownvs GORMQueryContextgoroutine)TestTranscriptionStreamContextCancellation,TestTranscriptionWithMockServer,TestMistralProvider_CustomAliasChatStreamUsesBaseCompatibilityAndAliasMetadata— data race incore/providers/utils/utils.goSetupStreamCancellationType of change
Affected areas
How to test
Breaking changes
Security considerations
None — CI configuration only, no runtime code changed.
Checklist
Generated by Claude Code