FFU vm and WinPE time zone fix#128
Closed
JonasKloseBW wants to merge 1 commit intorbalsleyMSFT:devfrom
Closed
Conversation
…one to improve image timestamp values - Enable Time Synchronization service for FFU vms - Set the time zone to the local time zone for the FFU image - Set the time zone to the local time zone for the WinPE capture image
Contributor
Author
|
Testing works fine inside the FFU vm and for the ffu file name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capturing FFU vm and Windows PE use a pre-set time zone of GMT-8. This is alright for most purposes. However if you're building images in different locations in the US or in the UK, the offset can become a noticeable irritation. This should allow users to see the local time stamps for the FFU vm logs as well for the captured FFU file name.
It might be a good idea to also offer UTC+0 time or a specific time zone provided through a parameter, depending on demand.