fix: use artifactId for DAP projectName instead of directory name#253
Merged
fix: use artifactId for DAP projectName instead of directory name#253
Conversation
Fixes issue #250 where debug mode fails when module folder name != artifactId. The DAP configuration now uses the Maven artifactId (or Gradle project name) instead of the directory name for the projectName, which is required by nvim-jdtls to resolve the java executable correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
projectNameinstead of directory nameChanges
get_artifact_idmethod to build tools (maven reads from pom.xml, gradle uses directory name)module.nameinstead ofroot:name()in debug configurationTesting