Add Charliecloud docs, git-revision-date plugin, and various updates#244
Open
Add Charliecloud docs, git-revision-date plugin, and various updates#244
Conversation
pnsinha
requested review from
vadim-cherepanov
and removed request for
vadim-cherepanov
vadim-cherepanov
requested changes
Apr 15, 2026
Collaborator
vadim-cherepanov
left a comment
vadim-cherepanov
left a comment
There was a problem hiding this comment.
All good! I had some problems with a few commands (worked without the docker:// part), where the images are stored, and mounting. A few other minor suggestions as well.
Collaborator
|
@pnsinha could you please address @vadim-cherepanov reviews so that we can merge the PR? |
- Remove invalid docker:// prefix from ch-image pull and ch-convert - Fix storage path from ~/.charliecloud/ to /var/tmp/pnsinha.ch/img/ - Use image names instead of full paths for ch-run commands - Fix bind mount destinations to use existing /mnt/0-9 mount points - Add warning about bind mount destination requirement - Document CH_IMAGE_STORAGE and -s flag for custom storage - Reorder best practices (bind mounts before host MPI) - Update docs link to charliecloud.io/latest/ - Note git-revision-date-localized-plugin pip dependency in mkdocs.yml Addresses review feedback from PR #244.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdocs-git-revision-date-localized-pluginto show last updated dates on pages