Release jobs which cause exceptions back to the queue#23
Open
tremby wants to merge 1 commit intorcrowe:masterfrom
tremby:retry-job-on-exception
Open
Release jobs which cause exceptions back to the queue#23tremby wants to merge 1 commit intorcrowe:masterfrom tremby:retry-job-on-exception
tremby wants to merge 1 commit intorcrowe:masterfrom
tremby:retry-job-on-exception
Conversation
From @pulkitjalan's patch 5ae35ae If an exception is encountered while working on a queued job to submit an error to Sentry, this exception would be caught and added to the queue as another job. This can snowball and cause all sorts of problems. Instead, catch any exception thrown when trying to submit an error and ignore it, instead releasing the original error submission job back to the queue after a delay. Note that this does not protect against similar issues when synchronously submitting error reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @pulkitjalan's patch 5ae35ae
If an exception is encountered while working on a queued job to submit an error to Sentry, this exception would be caught and added to the queue as another job. This can snowball and cause all sorts of problems; see #14.
Instead, catch any exception thrown when trying to submit an error and ignore it, instead releasing the original error submission job back to the queue after a delay.
Note that this does not protect against similar issues when synchronously submitting error reports.
This fixes #14 and possibly #16.