Skip to content

[codex] Review selected validation report adapter - #461

Merged
rcs2153 merged 1 commit into
mainfrom
codex/selected-consumer-report-adapter-review
Aug 11, 2026
Merged

[codex] Review selected validation report adapter#461
rcs2153 merged 1 commit into
mainfrom
codex/selected-consumer-report-adapter-review

Conversation

@rcs2153

@rcs2153 rcs2153 commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • add the focused maintainer review for the selected project-validation WorkReport adapter
  • accept the fresh-run composition path and record one blocker in existing-terminal reassessment provenance
  • keep the selected approval adoption envelope and CLI cutover deferred until a fresh-time semantic reassessment fix is implemented and reviewed

Finding

Existing-terminal reassessment reruns the canonical check while assigning the original runtime-fact snapshot evaluation time to the new observation. The fix must use a fresh Core-owned reassessment time, compare stable semantic commitments with the durable original binding, preserve durable run history, and fail closed on drift.

Validation

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test -p workflow-core --test local_executor selected_project_validation_report_adapter (4 passed)
  • cargo test --workspace
  • npm run check:docs
  • git diff --check

Governed Review

  • workflow: dg/review
  • run: run-1786459757904591000-2
  • approval: approval/run-1786459757904591000-2/review-scope-approved
  • presentation: presentation/e5c812d580aa1828
  • outcome: granted with persisted proof
  • close: Completed, 39 events, 0 retries, 0 escalations

No runtime behavior, CLI behavior, schemas, provider mutation, or persistence changes are included.

@rcs2153
rcs2153 marked this pull request as ready for review August 11, 2026 18:04
@rcs2153
rcs2153 merged commit e1cc93c into main Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant