[codex] Review selected validation report adapter - #461
Merged
Conversation
rcs2153
marked this pull request as ready for review
August 11, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finding
Existing-terminal reassessment reruns the canonical check while assigning the original runtime-fact snapshot evaluation time to the new observation. The fix must use a fresh Core-owned reassessment time, compare stable semantic commitments with the durable original binding, preserve durable run history, and fail closed on drift.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p workflow-core --test local_executor selected_project_validation_report_adapter(4 passed)cargo test --workspacenpm run check:docsgit diff --checkGoverned Review
dg/reviewrun-1786459757904591000-2approval/run-1786459757904591000-2/review-scope-approvedpresentation/e5c812d580aa1828No runtime behavior, CLI behavior, schemas, provider mutation, or persistence changes are included.