Fix dogfood proof discovery at scale - #466
Merged
Merged
Conversation
rcs2153
marked this pull request as ready for review
August 12, 2026 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the repo-local governed phase runner so phase-close reads approval-presentation records from the target run's canonical SHA-256-partitioned directory instead of scanning every run in the shared store.
Root cause
The helper scanned the complete approval-presentation record tree and failed closed after 250 records. Once normal dogfood history exceeded that global bound, a valid target-run presentation proof became undiscoverable even though Core already stores records under a per-run hash directory.
Changes
Validation
npm run test:dogfood-helper(32 passed)npm run check:docsnpm run check:integrationsgit diff --checkdg/blockerphase-close returnedapproval_presentation_enforcement: proof_enforcedGoverned phase
dg/blockerrun-1786536294355921000-2approval/run-1786536294355921000-2/fix-approvedpresentation/7556ba28af9f5510dg/prrun-1786537818969755000-2approval/run-1786537818969755000-2/pr-scope-approvedBoundary
No Core runtime or approval semantics, persistence format, workflow specs, schemas, provider behavior, report artifacts, hosted behavior, external writes, or release posture changed. Repository edits, checks, git operations, and this PR were performed outside the kernel and are disclosed here.