Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d212a5a58b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Controller helpers: | ||
| - SISO pole placement | ||
| - Discrete LQR | ||
| - Continuous LQR approximation | ||
| - Closed-loop assembly (`A-BK`) |
There was a problem hiding this comment.
Remove non-existent controller APIs from README highlights
The README now advertises controller helpers (pole placement/LQR/closed-loop assembly), but this commit’s public API only exposes analysis, model, simulator, and trajectory modules (src/lib.rs), so users relying on these bullets will look for APIs that are not present and hit compile-time failures when trying to adopt the library from documentation alone. Please align the highlights with what this revision actually ships.
Useful? React with 👍 / 👎.
This changelog summarizes the work developed on branch
11-refactor-model-analysis.Added
ContinuousStateSpaceModel::try_from_matrices(...)DiscreteStateSpaceModel::try_from_matrices(...)ModelError(MatrixANotSquare,DimensionMismatch,InvalidSamplingDt,SingularMatrix)analysis::analyze_lti(...)TimeDomain(Continuous,Discrete)LtiAnalysisReport(poles, spectral radius, stability, controllability/observability diagnostics)simulate(...)examples/analysis_report.rsChanged
y = Cx + Dumodel.rswith equations and assumptionsapt-get update+libfontconfig1-dev)Removed
simulate_with_noise(...)(kept simulator scope deterministic)Breaking Changes
Quality / Verification
cargo test(unit tests + doctests)