webconfig: add Mode field support for radio capability#1110
Open
nefiguclu wants to merge 12 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new Mode attribute in the radio capability webconfig flow so it is carried end-to-end (decode → internal storage → EasyMesh translation → encode).
Changes:
- Encode
Modeinto the radiocap JSON payload (radiocap->mode[0]). - Decode
Modefrom incoming radiocap JSON intoradio_cap->mode[0]. - Propagate the decoded
Modeinto EasyMesh radio capability translation (cap_info->mode).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/webconfig/wifi_encoder.c | Adds Mode to radiocap JSON output. |
| source/webconfig/wifi_decoder.c | Parses Mode from radiocap JSON into radio_cap->mode[0]. |
| source/webconfig/wifi_easymesh_translator.c | Copies radio_cap->mode[0] into the EasyMesh radio cap info (cap_info->mode). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pavlo-Uvarov
approved these changes
May 13, 2026
Nikita-Hakai
force-pushed
the
max_standards
branch
from
26f8bc0 to
f5b51ed
Compare
Contributor
|
Internal build success: https://gerrit.teamccp.com/#/c/956568/ |
Add support for new "Mode" parameter in radio capability webconfig encode/decode flow. The Mode value is now parsed from incoming JSON, stored in radio_cap->mode[0], and propagated to EasyMesh translation and encoder output. Issue: RDKBWIFI-428 Signed-off-by: Nefi Guclu <guclunefi@gmail.com>
Nikita-Hakai
force-pushed
the
max_standards
branch
from
f5b51ed to
012c3d4
Compare
Contributor
Author
|
Hello @Nikita-Hakai, If this PR looks good to you as it is, could you please merge it? |
…kcentral#1138) Reason for change: Added Fix as per the build error Test Procedure: Load the OneWifi Image and verify as per Split brain Feature scenario. Risks: Low Signed-off-by: aishwaryaashok_medpalliwar@comcast.com Co-authored-by: yanaki_mahesh@comcast.com Co-authored-by: sachinkumar_shah@comcast.com Signed-off-by: aishwaryaashok_medpalliwar@comcast.com Co-authored-by: amedpa922 < aishwaryaashok_medpalliwar@comcast.com> Co-authored-by: Sathish Kumar Gnanasekaran <gsathish86@gmail.com>
…ction (rdkcentral#1128) Co-authored-by: Raja Shah <167130396+rshah-1@users.noreply.github.com>
…l#1143) * Propagating tcm_enabled_rfc state to Vap specific RFC based on cloud push after reset * update * Update cosa_wifi_dml.c --------- Co-authored-by: Sathish Kumar Gnanasekaran <gsathish86@gmail.com>
… counters (rdkcentral#1141) Reason for Change: Existing command used awk '{print $6} to extract the rxprobereq value, but the counter output is a single long line with multiple key-value pairs. Field $6 was pointing to wrong counter rxauth_req_denied and not rxprobereq Fixed by using grep -o "rxprobereq" [0-9]*" which directly extracts only the rxorobereq value and awk '{print $2}' to get the correct count Changed done in both 2GHz and 5GHz pre and cur counters Signed-off-by: Sake Victor Daniel <VictorDaniel_Sake@comcast.com> Co-authored-by: Sathish Kumar Gnanasekaran <gsathish86@gmail.com>
…ment insertion (rdkcentral#1146) Reason for change: Memory leak in onewifi process Test Procedure: Debug Priority: P1 Risks: Low (cherry picked from commit d6c1379) Signed-off-by: Petro Krynytskyi <petr0krynytskiy@gmail.com> Co-authored-by: Narendra Varma Dandu <narendandu@gmail.com>
…ependent L1 tests (rdkcentral#702) * RDKBWIFI-206: add mocks and build for platform independent L1 tests on-behalf-of: @permanence-ai <github-ai@permanence.ai> * RDKBWIFI-206: add unittests for wifi_ctrl_webconfig.c on-behalf-of: @permanence-ai <github-ai@permanence.ai> * remove symbols that are no longer necessary to mock on-behalf-of: @permanence-ai <github-ai@permanence.ai> * update mockplatform/makefile to match recent updates * remove wifi_sensing from the Makefile again to work with latest changes * more explicitly use the rpi setup.sh script as the intent is to be identical * minor naming conventions and typo updates * update mockplatform makefile for multi_ap includes
* RDKBWIFI-359: BTM Query support Signed-off-by: prashant-singh1 <prashant.singh8521@gmail.com> * RDKBWIFI-359: BTM Query support Signed-off-by: prashant-singh1 <prashant.singh8521@gmail.com> * RDKBWIFI-359: BTM Query support --------- Signed-off-by: prashant-singh1 <prashant.singh8521@gmail.com> Co-authored-by: Narendra Varma Dandu <narendandu@gmail.com>
Reason for change: Avoid unnecessary free and malloc when the data length is same. Test Procedure: Debug Risks: Low Priority: P1 Signed-off-by: Petro Krynytskyi <Petr0krynytskiy@gmail.com> Co-authored-by: Narendra Varma Dandu <narendandu@gmail.com>
Reason for change: Missing mapping causes reboot. Test Procedure: Enable CSI collection for client device, ensure it can be turned off or that the timer for collection times out without issues. Risks: None Priority: P1 Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com> Co-authored-by: Sathish Kumar Gnanasekaran <gsathish86@gmail.com>
Add support for new "Mode" parameter in radio capability webconfig encode/decode flow. The Mode value is now parsed from incoming JSON, stored in radio_cap->mode[0], and propagated to EasyMesh translation and encoder output. Issue: RDKBWIFI-428 Signed-off-by: Nefi Guclu <guclunefi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for new "Mode" parameter in radio capability webconfig encode/decode flow. The Mode value is now parsed from incoming JSON, stored in radio_cap->mode[0], and propagated to EasyMesh translation and encoder output.
Issue: RDKBWIFI-428
Dep PR: rdkcentral/unified-wifi-mesh#672