Update DML if HAL params change when applying#1133
Draft
bmilcz-comcast wants to merge 1 commit into
Draft
Conversation
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
a4da566 to
9641ce3
Compare
This was referenced May 21, 2026
| return TIMER_TASK_COMPLETE; | ||
| } | ||
|
|
||
| int update_global_cache(wifi_vap_info_map_t *tgt_vap_map, rdk_wifi_vap_info_t *rdk_vap_info) |
Contributor
There was a problem hiding this comment.
Since it's being used in other translation units add declaration to one of the headers and include in each translation unit that uses it outside of this one.
Comment on lines
+195
to
+203
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( | ||
| sizeof(webconfig_subdoc_data_t)); | ||
|
|
||
| if (dml_cache_update_subdoc == NULL) { | ||
| wifi_util_error_print(WIFI_CTRL, | ||
| "%s:%d: malloc failed to allocate webconfig_subdoc_data_t, size %d\n", __func__, | ||
| __LINE__, sizeof(webconfig_subdoc_data_t)); | ||
| return -1; | ||
| } |
Contributor
There was a problem hiding this comment.
Allocate memory right before it's used, not here.
Suggested change
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( | |
| sizeof(webconfig_subdoc_data_t)); | |
| if (dml_cache_update_subdoc == NULL) { | |
| wifi_util_error_print(WIFI_CTRL, | |
| "%s:%d: malloc failed to allocate webconfig_subdoc_data_t, size %d\n", __func__, | |
| __LINE__, sizeof(webconfig_subdoc_data_t)); | |
| return -1; | |
| } | |
| webconfig_subdoc_data_t *dml_cache_update_subdoc = NULL; |
And remove all those free(dml_cache_update_subdoc); that follow.
| wifi_vap_info_map_t *tmp_vap_map = NULL; | ||
| bool dml_cache_update_needed = false; | ||
|
|
||
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( |
Contributor
There was a problem hiding this comment.
Same as before - don't allocate memory, until it's being used.
| char update_status[128]; | ||
| bool dml_cache_update_needed = false; | ||
|
|
||
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( |
Contributor
There was a problem hiding this comment.
Same as before - don't allocate memory, until it's being used.
| char update_status[128], old_sec_mode[32], new_sec_mode[32]; | ||
| bool dml_cache_update_needed = false; | ||
|
|
||
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( |
Contributor
There was a problem hiding this comment.
Same as before - don't allocate memory, until it's being used.
| int ret = 0; | ||
|
|
||
| bool dml_cache_update_needed = false; | ||
| webconfig_subdoc_data_t *dml_cache_update_subdoc = (webconfig_subdoc_data_t *)malloc( |
Contributor
There was a problem hiding this comment.
Same as before - don't allocate memory, until it's being used.
Comment on lines
+304
to
+315
| if (dml_cache_update_needed) { | ||
| wifi_ctrl_t *ctrl = (wifi_ctrl_t *)get_wifictrl_obj(); | ||
| ctrl->webconfig_state |= ctrl_webconfig_state_vap_all_cfg_rsp_pending; | ||
| if (webconfig_encode(&ctrl->webconfig, dml_cache_update_subdoc, | ||
| webconfig_subdoc_type_dml) == webconfig_error_none) { | ||
| wifi_util_info_print(WIFI_CTRL, "%s:%d webconfig_encode success\n", __FUNCTION__, | ||
| __LINE__); | ||
| } else { | ||
| wifi_util_error_print(WIFI_CTRL, "%s:%d webconfig_encode failed\n", __FUNCTION__, | ||
| __LINE__); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I saw these chunks of code are repeating. I think you can move them into separate function and call that function instead.
Using WebConfig we are synchronizing the current manager cache with DML cache if params that were passed down to createVAP() change after the function finalizes.
bmilcz-comcast
force-pushed
the
dml_cache_updates_fix
branch
from
9641ce3 to
d0fcfd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using WebConfig we are synchronizing the current manager cache with DML cache if params that were passed down to createVAP() change after the funcion finalizes.