RDKBWIFI-278: CLIENT ASSOC CTRL REQUEST Improvement#1137
Open
sundram0711 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
community contribution
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves EasyMesh “client assoc control” handling by resolving the correct vap_index from a provided BSSID and by attempting to cancel scheduled unblock timers when an unblock request arrives for a previously blocked station.
Changes:
- Added
em_get_vap_index_from_bssid()and switched client assoc control logic to use it (instead of deriving an index via radio MAC). - Introduced a pending-block tracking list to support canceling scheduled ACL removal timers on unblock requests.
- Extended
kick_details_tto include atimer_idfield intended for timer cancellation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
source/core/wifi_ctrl.h |
Extends kick_details_t with timer_id to track scheduled tasks. |
source/apps/em/wifi_em.c |
Adds BSSID→VAP index utility + pending timer tracking/cancellation logic for client assoc control. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sundram0711
force-pushed
the
easymesh-client_assoc_improvement
branch
3 times, most recently
from
634d506 to
ccc08f9
Compare
| policy_config->radio_metrics_policies.radio_count = 0; | ||
|
|
||
| // Initialize pending blocks list mutex | ||
| pthread_mutex_init(&pending_blocks_lock, NULL); |
Contributor
There was a problem hiding this comment.
I don't see anywhere pthread_mutex_destroy(&pending_blocks_lock)
Contributor
Author
There was a problem hiding this comment.
Yes right, now added it.
Added a utility function to get the correct vap_index from bssid Used that utility in the client assoc ctrl implementaiton. Added a helper to cancel the timer if unblock request comes for the blocked stations. Signed-off-by: Sundram Patel <sundram.p@tataelxsi.co.in>
sundram0711
force-pushed
the
easymesh-client_assoc_improvement
branch
from
ccc08f9 to
a71413b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a utility function to get the correct vap_index from bssid Used that utility in the client assoc ctrl implementaiton.
Added a helper to cancel the timer if unblock request comes for the blocked stations.