Skip to content

WPA3_PCM_MFP_Optional #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KarthikeyanNanjundan wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

WPA3_PCM_MFP_Optional #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/core/wifi_ctrl_queue_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4139,7 +4139,7 @@ void process_rsn_override_rfc(bool type)
}
vapInfo->u.bss_info.security.mode = wifi_security_mode_wpa3_compatibility;
vapInfo->u.bss_info.security.u.key.type = wifi_security_key_type_psk_sae;
vapInfo->u.bss_info.security.mfp = wifi_mfp_cfg_disabled;
vapInfo->u.bss_info.security.mfp = wifi_mfp_cfg_optional;

#if defined(CONFIG_IEEE80211BE)
if (radio_params->band == WIFI_FREQUENCY_6_BAND) {
Expand Down
2 changes: 1 addition & 1 deletion source/core/wifi_multidoc_webconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ static int decode_security_blob(wifi_vap_info_t *vap_info, cJSON *security, pErr
} else if (!strcmp(value, "WPA3-Personal-Compatibility")) {
vap_info->u.bss_info.security.mode = wifi_security_mode_wpa3_compatibility;
vap_info->u.bss_info.security.u.key.type = wifi_security_key_type_psk_sae;
vap_info->u.bss_info.security.mfp = wifi_mfp_cfg_disabled;
vap_info->u.bss_info.security.mfp = wifi_mfp_cfg_optional;
#if defined(CONFIG_IEEE80211BE)
if( strstr(vap_info->vap_name, "6g") ) {
vap_info->u.bss_info.security.u.key.type = wifi_security_key_type_sae;
Expand Down
4 changes: 2 additions & 2 deletions source/webconfig/wifi_decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,9 +1493,9 @@ webconfig_error_t decode_security_object(const cJSON *security, wifi_vap_securit
((band == WIFI_FREQUENCY_6_BAND &&
security_info->mfp != wifi_mfp_cfg_required) ||
(band != WIFI_FREQUENCY_6_BAND &&
security_info->mfp != wifi_mfp_cfg_disabled))) {
security_info->mfp != wifi_mfp_cfg_optional))) {
#else
security_info->mfp != wifi_mfp_cfg_disabled) {
security_info->mfp != wifi_mfp_cfg_optional) {
#endif /* CONFIG_IEEE80211BE */
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d Invalid MFP Config %d for %d mode \n",
__func__, __LINE__, security_info->mfp, security_info->mode);
Expand Down
4 changes: 2 additions & 2 deletions source/webconfig/wifi_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,9 +1227,9 @@ webconfig_error_t encode_security_object(const wifi_vap_security_t *security_inf
((is_6g == true &&
security_info->mfp != wifi_mfp_cfg_required) ||
(is_6g == false &&
security_info->mfp != wifi_mfp_cfg_disabled))) {
security_info->mfp != wifi_mfp_cfg_optional))) {
#else
security_info->mfp != wifi_mfp_cfg_disabled) {
security_info->mfp != wifi_mfp_cfg_optional) {
#endif /* CONFIG_IEEE80211BE */
wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d Invalid MFP Config %d for %d mode \n",
__func__, __LINE__, security_info->mfp, security_info->mode);
Expand Down
2 changes: 2 additions & 0 deletions source/webconfig/wifi_ovsdb_translator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,8 @@ void get_translator_config_wpa_mfp(
} else if (vap->u.bss_info.security.mode == wifi_security_mode_wpa3_transition ||
vap->u.bss_info.security.mode == wifi_security_mode_wpa2_personal) {
vap->u.bss_info.security.mfp = wifi_mfp_cfg_optional;
} else if (vap->u.bss_info.security.mode == wifi_security_mode_wpa3_compatibility) {
vap->u.bss_info.security.mfp = wifi_mfp_cfg_optional;
} else {
vap->u.bss_info.security.mfp = wifi_mfp_cfg_disabled;
}
Expand Down
Loading