RDKB-63040: [TXB7/TXB8]: Observed Packet Error Count Marker updated with large Values

[MothiShree]

Reason for change: Counter wrapped and subtraction logic failed at the marker polling.
Test Procedure:

1. Set the loginterval as 5min
2. Connect a client and run high traffic.
3. After reaching the traffic, check the errorssent marker value has been polled as 4294967295.
   Priority: P1
   Risks: Low
   Signed-off-by: mothishree_mallaiyanjothimani@comcast.com

[Copilot]

Pull request overview

This PR updates WHiX client telemetry counter delta calculations to handle counter wrap-around when polling per-client stats (notably error/packet counters), preventing incorrect large marker values after rollover.

Changes:

• Introduces wrap-around aware delta computation for multiple per-client counters (bytes, packets, errors, retrans/retry counts).
• Adds temporary variables (curr, prev, diff) to compute deltas safely instead of direct subtraction.

Comments suppressed due to low confidence (3)

source/apps/whix/wifi_whix.c:1595

• strncat() into telemetryBuff uses a bound computed from strlen(buff) instead of strlen(telemetryBuff). This can prematurely truncate telemetryBuff and is easy to break if buff/telemetryBuff formats diverge. Compute the remaining capacity based on telemetryBuff when appending to telemetryBuff.

                strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
                strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
            }

source/apps/whix/wifi_whix.c:1663

• strncat() into telemetryBuff uses a bound computed from strlen(buff) instead of strlen(telemetryBuff). This can prematurely truncate telemetryBuff and is easy to break if buff/telemetryBuff formats diverge. Compute the remaining capacity based on telemetryBuff when appending to telemetryBuff.

                strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
                strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
            }

source/apps/whix/wifi_whix.c:1701

• strncat() into telemetryBuff uses a bound computed from strlen(buff) instead of strlen(telemetryBuff). This can prematurely truncate telemetryBuff and is easy to break if buff/telemetryBuff formats diverge. Compute the remaining capacity based on telemetryBuff when appending to telemetryBuff.

                strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
                strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.