Probable link type fix#2126
Draft
Karthick-Somasundaresan wants to merge 13 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to make JSONRPCLink’s per-connection cache (channelMap) shared across DSOs by moving the map into the WebSocket library’s data segment, and updates the key to avoid collisions between different LinkType<INTERFACE> specializations.
Changes:
- Introduces an exported
CommunicationChannelBaseand a shared, exportedGetChannelMap()accessor for a single globalProxyMapType. - Switches
CommunicationChannel::Instance()to use the shared map and adds an interface discriminator to the map key. - Minor formatting-only change in
Source/core/Proxy.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/websocket/JSONRPCLink.h | Adds exported base type + shared map accessor and updates channel instance caching/keying logic. |
| Source/websocket/JSONRPCLink.cpp | Implements GetChannelMap() as a function-local static stored in the library. |
| Source/core/Proxy.h | Formatting-only change (blank line). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
215
to
218
|
|
||
| return (channelMap.template Instance<CommunicationChannel>(searchLine, remoteNode, callsign, query)); | ||
| return Core::ProxyType<CommunicationChannel>(GetChannelMap().template Instance<CommunicationChannel>(searchLine, remoteNode, callsign, query)); | ||
| } | ||
|
|
Comment on lines
+210
to
212
| ~CommunicationChannel() override = default; | ||
| static Core::ProxyType<CommunicationChannel> Instance(const Core::NodeId& remoteNode, const string& callsign, const string& query) | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.