Skip to content

[R4_4][IMessageControl] Backporting#495

Merged
MFransen69 merged 6 commits into
R4_4from
development/messaging-backporting
May 29, 2026
Merged

[R4_4][IMessageControl] Backporting#495
MFransen69 merged 6 commits into
R4_4from
development/messaging-backporting

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 8, 2026 07:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports updates to the Exchange::IMessageControl interface to align it with newer Thunder messaging metadata and JSON-RPC generation expectations.

Changes:

  • Replaces the local messagetype enum with Core::Messaging::Metadata::type and adds a JSON annotation/version line.
  • Switches interface method return types from uint32_t to Core::hresult.
  • Adds a Modules() property and changes Controls() to be module-indexed (module-specific controls).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread interfaces/IMessageControl.h
Copilot AI review requested due to automatic review settings May 8, 2026 11:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread interfaces/IMessageControl.h
Comment thread interfaces/IMessageControl.h Outdated
Copilot AI review requested due to automatic review settings May 8, 2026 13:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread interfaces/IMessageControl.h
Comment thread interfaces/IMessageControl.h
Comment thread interfaces/IMessageControl.h Outdated
@sebaszm sebaszm requested a review from MFransen69 May 9, 2026 05:51
Comment thread interfaces/IMessageControl.h Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 29, 2026 09:17
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@MFransen69 MFransen69 merged commit 3e0ec24 into R4_4 May 29, 2026
21 checks passed
@MFransen69 MFransen69 deleted the development/messaging-backporting branch May 29, 2026 09:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants