PSG - Bug fixes for interfaces such as IBrowser.h by nxtum · Pull Request #240 · rdkcentral/ThunderTools

nxtum · 2026-02-26T12:54:03Z

No description provided.

rdkcmf-jenkins · 2026-02-26T12:55:09Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderTools/240/rdkcentral/ThunderTools
Commit: 587658f

Report detail: gist'

Copilot

Pull request overview

This PR updates the Plugin Skeleton Generator to better handle real-world Thunder interface headers (e.g., optional EXTERNAL, nested types/aliases used by notification signatures), improves notification code generation, and adds support for choosing an output directory.

Changes:

Extend interface parsing to capture using aliases and nested type declarations for more robust parameter type qualification in generated notification code.
Add generation support for notification helper implementations in source, selective JSON “J*” includes, and optional OOP configuration scaffolding.
Allow the generator to emit the plugin into a user-selected output directory and update scripts/templates accordingly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
PluginSkeletonGenerator/utils/FileUtils.py	Adds a post-processing pass to normalize generated output around `Metadata<...>` token spacing.
PluginSkeletonGenerator/templates/.plugin_source.txt	Adds `{{SOURCE_NOTIFY_IMPL}}` injection point in generated source.
PluginSkeletonGenerator/templates/.plugin_implementation.txt	Adds placeholders for copied `using` aliases and optional OOP configure method emission.
PluginSkeletonGenerator/templates/.plugin_header.txt	Makes the “private members” access specifier driven by a placeholder.
PluginSkeletonGenerator/parser/Parser.py	Improves interface detection (`EXTERNAL` optional) and captures `using` aliases + nested type names.
PluginSkeletonGenerator/menu/Menu.py	Adds output directory prompt, stricter yes/no handling, and plugin-name validation.
PluginSkeletonGenerator/generators/PluginRepositoryGenerator.py	Writes generated plugin under `output_dir/plugin_name` instead of always CWD.
PluginSkeletonGenerator/data/FileData.py	Adds type-qualification helpers for notification params, deduped includes, event-only JSON includes, and in-process notification implementations.
PluginSkeletonGenerator/core/PluginBlueprint.py	Tracks `@event` notification entries separately and adds `output_dir` to blueprint.
PluginSkeletonGenerator/core/GeneratorCoordinator.py	Threads `output_dir` through to the blueprint.
PluginSkeletonGenerator/CombinedPlugins.sh	Updates scripted stdin answers to match the new prompts (output dir added).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mhughesacn · 2026-02-26T13:14:12Z

Hi @nxtum : All code files are supposed to have proper Apache headers please.

rdkcmf-jenkins · 2026-02-26T13:38:37Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderTools/240/rdkcentral/ThunderTools
Commit: 807fd39

Report detail: gist'

rdkcmf-jenkins · 2026-02-26T13:42:08Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderTools/240/rdkcentral/ThunderTools
Commit: 3a2e837

Report detail: gist'

nxtum · 2026-02-26T13:43:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.
* Protex Server Path: /home/blackduck/github/ThunderTools/240/rdkcentral/ThunderTools

* Commit: [3a2e837](https://github.com/rdkcentral/ThunderTools/commit/3a2e837b145a32b2124ab696d18fd24573c3ebdc)
Report detail: gist'

it doesnt like the word token

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-26T14:05:41Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-22444624696/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-02-26T14:21:59Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/ThunderTools/240/rdkcentral/ThunderTools
Commit: 77997fc

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-26T14:27:10Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-22446053936/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

rdkcmf-jenkins · 2026-02-26T21:16:09Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Thank you
Commit: 77997fc
'

github-actions · 2026-02-27T11:06:43Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-22483695122/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

github-actions · 2026-03-02T14:24:51Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-22580185447/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-03-10T08:05:00Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-22892842439/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

VeithMetro

Good changes and many, many bug fixes, great job! I just found a few minor things in the generated plugins:

Preconditions/Terminations/Controls collapsed into Preconditions only
Across all *Preconditions skeleton variants (e.g. InProcessConfigPreconditions), the generator now puts every subsystem into Preconditions and leaves Terminations/Controls empty
Unnecessary const_cast in Revoked handlers?
In multiple files (e.g. OutOfProcess.cpp), the Revoked handler applies const_cast to a pointer already returned as non-const by QueryInterface. Is this necessary as we cannot always tell whether that is const or not? Can't we detect that somehow?
Spacing before commas in subsystem lists
Minor formatting issue: { subsystem::GRAPHICS , subsystem::NOT_GRAPHICS , subsystem::TIME } has spaces before commas

nxtum · 2026-03-16T09:29:55Z

2. **Unnecessary const_cast in Revoked handlers?**
   In multiple files (e.g. OutOfProcess.cpp), the Revoked handler applies const_cast to a pointer already returned as non-const by QueryInterface. Is this necessary as we cannot always tell whether that is const or not? Can't we detect that somehow?

@VeithMetro

            template <typename REQUESTEDINTERFACE>
            REQUESTEDINTERFACE* QueryInterface()
            {
                void* baseInterface(QueryInterface(REQUESTEDINTERFACE::ID));

                if (baseInterface != nullptr) {
                    return (reinterpret_cast<REQUESTEDINTERFACE*>(baseInterface));
                }

                return (nullptr);
            }

            template <typename REQUESTEDINTERFACE>
            const REQUESTEDINTERFACE* QueryInterface() const
            {
                const void* baseInterface(const_cast<IUnknown*>(this)->QueryInterface(REQUESTEDINTERFACE::ID));

                if (baseInterface != nullptr) {
                    return (reinterpret_cast<const REQUESTEDINTERFACE*>(baseInterface));
                }

                return (nullptr);
            }

As remote is a const Core::IUnknown*
auto* revokedInterface = remote->QueryInterfaceExchange::IBrowser::INotification();
will call:

const REQUESTEDINTERFACE* QueryInterface() const

and since then the unregister method wants an interface that is not const, the constcast is needed here

github-actions · 2026-03-30T11:26:45Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-23742287475/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-03-30T11:47:18Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-23742486391/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

VeithMetro

One last thing, it does not compile now, because we changed to C++17 lately, and we use it in Thunder now 😄 You have to make sure that the CMake files that are generated don't have C++11 hardcoded as they do now

github-actions · 2026-04-08T07:57:28Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-24124424803/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

PluginSkeletonGenerator/menu/Menu.py:244

In --config mode, header_lookup_test stays empty (it’s only populated in the interactive branch), but it’s still passed to GeneratorCoordinator as header_lookup. This causes generated JSON to miss $cppref entries because JSONData._generateCPPREF() iterates blueprint.header_lookup. Consider populating header_lookup_test for config mode too (e.g., unique os.path.basename(header_path) values from parsed_data/by_header), or pass the actual header list consistently in both modes and drop the unused header_lookup = { ... } variable here.

    displayParsedData(parsed_data)
    header_lookup_test = []
    if not args.config:
        print("Specify custom include locations for each interface header (press Enter for default 'interfaces'):")
        asked_headers = set()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-08T08:35:09Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-24124448275/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

github-actions · 2026-04-13T06:28:15Z

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-240/run-24328975392/

AI summary of generated diff:
AI summary unavailable (HTTP 403). Check workflow logs.

psg changes

587658f

Copilot AI review requested due to automatic review settings February 26, 2026 12:54

Copilot started reviewing on behalf of nxtum February 26, 2026 12:54 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Comment thread PluginSkeletonGenerator/data/FileData.py Outdated

Comment thread PluginSkeletonGenerator/templates/.plugin_header.txt

Comment thread PluginSkeletonGenerator/core/PluginBlueprint.py

apache and workflow

807fd39

workflow

3a2e837

Copilot AI review requested due to automatic review settings February 26, 2026 13:40

Copilot started reviewing on behalf of nxtum February 26, 2026 13:40 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Comment thread .github/workflows/PluginSkeletonGenerator.yml Outdated

Comment thread PluginSkeletonGenerator/menu/Menu.py Outdated

Apply suggestion from @Copilot - workflow

77997fc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 26, 2026 14:18

Copilot started reviewing on behalf of nxtum February 26, 2026 14:19 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Comment thread PluginSkeletonGenerator/data/FileData.py

Comment thread PluginSkeletonGenerator/data/FileData.py

Comment thread .github/workflows/PluginSkeletonGenerator.yml

nxtum added 2 commits February 27, 2026 03:02

workflow metadata

7b59312

merge

d96e18a

const_cast

731768e

Copilot AI review requested due to automatic review settings March 2, 2026 14:23

Copilot started reviewing on behalf of nxtum March 2, 2026 14:23 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Comment thread PluginSkeletonGenerator/menu/Menu.py

Comment thread PluginSkeletonGenerator/CombinedPlugins.sh

This comment was marked as outdated.

Sign in to view

nxtum requested a review from VeithMetro March 4, 2026 14:33

Add step to upload combined diff artifact

e1131fc

VeithMetro requested changes Mar 10, 2026

View reviewed changes

workflow fix, and spacing

a72cfa4

Copilot AI review requested due to automatic review settings March 30, 2026 11:23

Merge branch 'master' into PSG/December2025Fixes

9746c3e

Copilot started reviewing on behalf of nxtum March 30, 2026 11:23 View session

whitespace..........

1ca4247

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread PluginSkeletonGenerator/menu/Menu.py

VeithMetro self-requested a review March 30, 2026 13:02

VeithMetro requested changes Mar 30, 2026

View reviewed changes

nxtum and others added 2 commits April 7, 2026 05:09

use new c++ versions

ec30a5c

Merge branch 'master' into PSG/December2025Fixes

a155c8f

Copilot AI review requested due to automatic review settings April 8, 2026 07:56

Copilot started reviewing on behalf of nxtum April 8, 2026 07:56 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Merge branch 'master' into PSG/December2025Fixes

f81c4c7

VeithMetro self-requested a review April 13, 2026 06:27

VeithMetro approved these changes Apr 13, 2026

View reviewed changes

VeithMetro merged commit 40d60d0 into master Apr 22, 2026
104 checks passed

VeithMetro deleted the PSG/December2025Fixes branch April 22, 2026 07:23

github-actions Bot locked and limited conversation to collaborators Apr 22, 2026

Conversation

nxtum commented Feb 26, 2026

Uh oh!

rdkcmf-jenkins commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhughesacn commented Feb 26, 2026

Uh oh!

rdkcmf-jenkins commented Feb 26, 2026

Uh oh!

rdkcmf-jenkins commented Feb 26, 2026

Uh oh!

nxtum commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

rdkcmf-jenkins commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

rdkcmf-jenkins commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 27, 2026

Uh oh!

github-actions Bot commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

VeithMetro left a comment

Choose a reason for hiding this comment

Uh oh!

nxtum commented Mar 16, 2026

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

VeithMetro left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Apr 8, 2026