ProxyStubGenerator - Add INotificationExtended to default.h#253
Merged
Conversation
LuaGenerator ResultsChanges detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a missing forward declaration for PluginHost::IPlugin::INotificationExtended in ProxyStubGenerator/default.h so the ProxyStubGenerator can successfully parse/generate code for interfaces referencing this newer notification type (per Thunder PR rdkcentral/Thunder#2123).
Changes:
- Added forward declaration of
IPlugin::INotificationExtendedin the default forward-declarations header used by ProxyStubGenerator.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ProxyStubGenerator ResultsChanges detected. |
sebaszm
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with:
rdkcentral/Thunder#2123