Skip to content

[Actions] Only the relevant workflows should run after commits on a PR branch#257

Merged
VeithMetro merged 3 commits into
masterfrom
development/actions-tool-workflows-improvment
May 26, 2026
Merged

[Actions] Only the relevant workflows should run after commits on a PR branch#257
VeithMetro merged 3 commits into
masterfrom
development/actions-tool-workflows-improvment

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 25, 2026 11:26
Comment thread .github/workflows/JsonGenerator.yml Fixed
Comment thread .github/workflows/LuaGenerator.yml Fixed
Comment thread .github/workflows/PluginSkeletonGenerator.yml Fixed
Comment thread .github/workflows/ProxyStubGenerator.yml Fixed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several GitHub Actions workflows to avoid running expensive generator/build jobs on every new commit to an existing PR when the latest push doesn’t touch the workflow’s relevant directories.

Changes:

  • Added a changes job using dorny/paths-filter@v3 to detect whether the latest PR push (synchronize) touched relevant paths.
  • Gated key downstream jobs (e.g., Thunder, generate_lua, prepare) using needs: [changes] and conditional if: logic to skip when irrelevant.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/ProxyStubGenerator.yml Adds a changes job and gates the Thunder reusable workflow based on incremental PR changes.
.github/workflows/PluginSkeletonGenerator.yml Adds a changes job and gates Thunder and prepare so generator work only runs when latest PR push is relevant.
.github/workflows/LuaGenerator.yml Adds a changes job and gates generate_lua to run only when the latest PR push affects Lua/ProxyStub-related paths.
.github/workflows/JsonGenerator.yml Adds a changes job and gates Thunder based on incremental PR changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ProxyStubGenerator.yml Outdated
Comment thread .github/workflows/PluginSkeletonGenerator.yml Outdated
Comment thread .github/workflows/LuaGenerator.yml Outdated
Comment thread .github/workflows/JsonGenerator.yml Outdated
Copilot AI review requested due to automatic review settings May 25, 2026 13:03
@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-257/run-26401797570/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

ProxyStubGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-257/run-26401917046/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@github-actions
Copy link
Copy Markdown

ProxyStubGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@VeithMetro VeithMetro requested a review from sebaszm May 26, 2026 06:26
@VeithMetro VeithMetro merged commit 53fdc6a into master May 26, 2026
205 of 209 checks passed
@VeithMetro VeithMetro deleted the development/actions-tool-workflows-improvment branch May 26, 2026 08:06
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants