[Actions][R4_4] Only the relevant workflows should run after commits on a PR branch#258
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the generator-related GitHub Actions workflows on the R4_4 branch to avoid running expensive jobs on every PR branch update, and instead only run them when the latest PR synchronization actually touches files relevant to that workflow.
Changes:
- Added a lightweight
changesjob to detect whether the latest PRsynchronizeupdate modified relevant paths. - Gated the main generator/build jobs (
Thunder/generate_lua) on thechangesjob output so they only run when relevant files changed (or when the filter job is skipped on non-PR-sync events).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ProxyStubGenerator.yml | Adds a changes filter job and gates the reusable Thunder build workflow on “relevant” path changes for PR sync updates. |
| .github/workflows/LuaGenerator.yml | Adds a changes filter job and gates Lua generation (and downstream pages publishing) based on relevant path changes for PR sync updates. |
| .github/workflows/JsonGenerator.yml | Adds a changes filter job and gates the reusable Thunder build workflow on “relevant” path changes for PR sync updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LuaGenerator ResultsChanges detected. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
LuaGenerator ResultsChanges detected. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
LuaGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsChanges detected. |
LuaGenerator ResultsNo changes detected. |
ProxyStubGenerator ResultsChanges detected. |
JsonGenerator ResultsNo changes detected. |
JsonGenerator ResultsChanges detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Diff:R4.4.4]