Skip to content

[Actions] Manually check which workflow is relevant to avoid bugs#259

Merged
VeithMetro merged 1 commit into
masterfrom
development/actions-relevance-fix
May 27, 2026
Merged

[Actions] Manually check which workflow is relevant to avoid bugs#259
VeithMetro merged 1 commit into
masterfrom
development/actions-relevance-fix

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 26, 2026 10:26
@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several generator-related GitHub Actions workflows to determine “relevance” on pull_request synchronize events by querying the GitHub compare API, so expensive downstream jobs can be skipped when the latest pushed commit doesn’t touch the workflow’s target paths.

Changes:

  • Replaced dorny/paths-filter with a gh api repos/.../compare before...after check to compute a relevant output.
  • Removed the changes job-level if: so the job always runs and emits relevant (defaulting to true for non-pull_request/non-synchronize events).
  • Simplified downstream job conditions to if: needs.changes.outputs.relevant == 'true'.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/ProxyStubGenerator.yml Switches relevance detection to gh api compare and gates downstream jobs on relevant.
.github/workflows/PluginSkeletonGenerator.yml Same relevance check change; gates Thunder/prepare on relevant.
.github/workflows/LuaGenerator.yml Same relevance check change for Lua + ProxyStub paths; gates generation on relevant.
.github/workflows/JsonGenerator.yml Same relevance check change; gates downstream jobs on relevant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ProxyStubGenerator.yml
Comment thread .github/workflows/PluginSkeletonGenerator.yml
Comment thread .github/workflows/LuaGenerator.yml
Comment thread .github/workflows/JsonGenerator.yml
@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-259/run-26446808598/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@sebaszm sebaszm self-requested a review May 27, 2026 07:36
@VeithMetro VeithMetro merged commit 2515e14 into master May 27, 2026
155 of 156 checks passed
@VeithMetro VeithMetro deleted the development/actions-relevance-fix branch May 27, 2026 07:37
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants