RDKEMW-12176: UT Fail test - donot merge#71
Open
PreethiLakshmi91 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is described as a crash fix related to device deep sleep, but the provided diff only introduces an extra blank line in btrCore_AddDeviceToScannedDevicesArr() and does not change runtime behavior.
Changes:
- Adds a blank line between the
MEMCPY_S(...)call and subsequent trace logging in the service-data population loop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1192
to
1196
| lstFoundDevice.stAdServiceData[count].len = apstBTDeviceInfo->saServices[count].len; | ||
| MEMCPY_S(lstFoundDevice.stAdServiceData[count].pcData,lstFoundDevice.stAdServiceData[count].len, apstBTDeviceInfo->saServices[count].pcData, BTRCORE_MAX_SERVICE_DATA_LEN); | ||
|
|
||
|
|
||
| BTRCORELOG_TRACE ("ServiceData from %s\n", __FUNCTION__); |
PreethiLakshmi91
force-pushed
the
utFailTest
branch
from
376ff4d to
b78bc71
Compare
Reason for change: Crash fix Test Procedure: Device deepsleep causing the crash Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
PreethiLakshmi91
force-pushed
the
utFailTest
branch
from
b78bc71 to
b76619b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| lstFoundDevice.stAdServiceData[count].len = apstBTDeviceInfo->saServices[count].len; | ||
| MEMCPY_S(lstFoundDevice.stAdServiceData[count].pcData,lstFoundDevice.stAdServiceData[count].len, apstBTDeviceInfo->saServices[count].pcData, BTRCORE_MAX_SERVICE_DATA_LEN); | ||
|
|
||
|
|
| lstFoundDevice.stAdServiceData[count].len = apstBTDeviceInfo->saServices[count].len; | ||
| MEMCPY_S(lstFoundDevice.stAdServiceData[count].pcData,lstFoundDevice.stAdServiceData[count].len, apstBTDeviceInfo->saServices[count].pcData, BTRCORE_MAX_SERVICE_DATA_LEN); | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Crash fix
Test Procedure: Device deepsleep causing the crash
Risks: Low
Priority: P2