RDKEMW-14533: Coverity inclusion changes#73
Open
PreethiLakshmi91 wants to merge 1 commit into
Open
Conversation
Reason for change: Inclusion of coverity for BT Test Procedure: NA Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a native CI build path (intended for Coverity inclusion) by introducing dependency/bootstrap scripts and a GitHub Actions workflow to build BT-Core in a clean Ubuntu environment.
Changes:
- Added
build_dependencies.shto install packages and stage external headers/libs needed for building. - Added
cov_build.shto bootstrap autotools, configure, and build the component. - Added
.github/workflows/native_full_build.ymlto run the above scripts on PRs/pushes todevelop.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
build_dependencies.sh |
Installs build deps, stages telemetry + BlueZ headers, and builds a telemetry stub shared library. |
cov_build.sh |
Runs autotools bootstrap, configures with staged includes/libs, and builds targets. |
.github/workflows/native_full_build.yml |
New GitHub Actions workflow to run dependency setup + native build on ubuntu-latest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
+33
| cat << 'EOF' > telemetry_stub.c | ||
| int t2_init(void) { return 0; } | ||
| int t2_event_s(const char* n, const char* v) { return 0; } | ||
| int t2_event_f(const char* n, float v) { return 0; } | ||
| int t2_event_d(const char* n, double v) { return 0; } | ||
| EOF | ||
|
|
||
| gcc -shared -fPIC telemetry_stub.c \ | ||
| -o ${WORKSPACE}/external/lib/libtelemetry_msgsender.so |
Comment on lines
+15
to
+17
| echo "Setting up telemetry stub..." | ||
|
|
||
| git clone https://github.com/rdkcentral/telemetry.git |
Comment on lines
+35
to
+37
| echo "Setting up BlueZ legacy headers..." | ||
|
|
||
| git clone https://github.com/bluez/bluez.git |
| export CXXFLAGS="-Wno-error" | ||
| export LD_LIBRARY_PATH="${WORKSPACE}/external/lib" | ||
|
|
||
| ac_cv_header_telemetry_busmessage_sender_h=yes ./configure |
Comment on lines
+26
to
+27
| make -C src/bt-ifce -j$(nproc) | ||
| make -C src -j$(nproc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Inclusion of coverity for BT
Test Procedure: NA
Risks: Low
Priority: P2