RDKEMW-14533: btMgr Coverity inclusion changes#108
Closed
PreethiLakshmi91 wants to merge 1 commit into
Closed
Conversation
Reason for change: Inclusion of coverity for BT Test Procedure: NA Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a native build workflow and helper scripts intended to bootstrap dependencies (btcore + BlueZ headers) and perform a full autotools build of bluetooth_mgr in CI, supporting Coverity/native build inclusion.
Changes:
- Added
build_dependencies.shto install apt dependencies, clone/build/install btcore, and stage BlueZ legacy headers under a local prefix. - Added
cov_build.shto bootstrap autotools, configure, build, and installbluetooth_mgrusing the local prefix. - Added a GitHub Actions workflow to run the above scripts on PRs/pushes to
main/develop.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cov_build.sh |
Bootstraps autotools + configures/builds/installs bluetooth_mgr for a native CI build. |
build_dependencies.sh |
Installs system deps, clones/builds btcore, and stages required BlueZ headers into a local prefix. |
.github/workflows/native_full_build.yml |
New CI workflow wiring the dependency setup + native full build together. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| export PREFIX_PATH | ||
| export CPPFLAGS="-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I${PREFIX_PATH}/include -I${PREFIX_PATH}/include/cjson -I/usr/include/cjson" | ||
| export LDFLAGS="-L${PREFIX_PATH}/lib -lbtrCore" |
Comment on lines
+15
to
+19
| libtoolize --force | ||
| aclocal | ||
| automake --force-missing --add-missing | ||
| autoconf | ||
| autoreconf --install -f |
Comment on lines
+41
to
+43
| echo "Cloning bluetooth (btcore provider)..." | ||
| rm -rf "${WORKSPACE}/src/btrcore" | ||
| git clone https://github.com/rdkcentral/bluetooth.git "${WORKSPACE}/src/btrcore" |
Comment on lines
+65
to
+70
| libtoolize --force | ||
| aclocal | ||
| autoheader | ||
| automake --force-missing --add-missing | ||
| autoconf | ||
| autoreconf --install -f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Inclusion of coverity for BT
Test Procedure: NA
Risks: Low
Priority: P2