RDKEMW-16966: T2 Events for IRDB Programming#239
Open
klu339 wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds new Telemetry 2.0 (T2) markers and event emissions around IRDB (IR database) workflows—manual lookup APIs, autolookup, IR programming outcomes, and vendor selection—so IRDB programming behavior can be measured via aggregated telemetry.
Changes:
- Introduces new IRDB telemetry marker constants and emits new T2 events from IRDB IPC and BLE network/controller flows.
- Adds IR programming failure reason propagation through BLE status indications to improve telemetry fidelity.
- Adjusts EDID logging verbosity in the DisplaySettings Thunder plugin.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/thunder/plugins/ctrlm_thunder_plugin_display_settings.cpp | Changes EDID dump logging level (now INFO). |
| src/telemetry/ctrlm_telemetry_markers.h | Adds IRDB telemetry marker definitions and format comments. |
| src/irdb/ipc/ctrlm_irdb_ipc_iarm_thunder.cpp | Emits IRDB “manual result” telemetry events for IARM calls. |
| src/irdb/ctrlm_irdb_interface.cpp | Captures autolookup outcomes and emits an autolookup telemetry event. |
| src/ble/ctrlm_ble_rcu_interface.cpp | Populates IEEE address and failure reason in IR programming status indications. |
| src/ble/ctrlm_ble_network.cpp | Emits IR programming result telemetry based on IR state changes / unsupported IRDB path. |
| src/ble/ctrlm_ble_controller.cpp | Emits vendor-set telemetry after attempting to set preferred IRDB vendor. |
| include/ctrlm_hal_ble.h | Extends BLE status struct with ir_fail_reason field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.