RDKEMW-16730 : Evaluation on finding invalid markers in entservices repos

[srinibas15]

Reason For Change: Replacing with the required events for Invalid markers
Test procedure : Compile and Verify
version: patch
Priority: P2

[Copilot]

Pull request overview

This PR updates a small set of telemetry marker names in the device settings RPC services so the emitted events use the required *_split identifiers instead of the previous invalid markers.

Changes:

• Renamed the persistent HDMI 4K resolution telemetry event in dsVideoPort.
• Renamed the HDMI Rx Sense OFF telemetry event in dsDisplay.
• Renamed two passthrough-related audio telemetry events in dsAudio.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
rpc/srv/dsVideoPort.c	Updates the HDMI resolution telemetry marker emitted during video port manager initialization.
rpc/srv/dsDisplay.c	Updates the telemetry marker sent when Rx Sense changes to OFF.
rpc/srv/dsAudio.c	Updates telemetry markers for ARC passthrough initialization and persisted passthrough mode changes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

rpc/srv/dsAudio.c:2755

• This block still allocates and formats telemetryValue but no longer uses it after switching to TELEMETRY_EVENT_INT, and it also leaves a commented-out TELEMETRY_EVENT_STRING call. Please remove the unused formatting and the commented-out code (or re-enable it if still required) to avoid dead code and confusion about which marker should be emitted.

                    char telemetryValue[128] = {0};
                    snprintf(telemetryValue, sizeof(telemetryValue), "The HDMI Audio Mode Setting From Persistent is %d", param->toPersist);
                    // TELEMETRY_EVENT_STRING("SYS_INFO_Userpassthruenable_split", telemetryValue);
                    TELEMETRY_EVENT_INT("SYS_INFO_Userpassthruenable", 1);

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

rpc/srv/dsAudio.c:2755

• This block now has dead code and leftover commented-out telemetry: telemetryValue is formatted but not used, and the commented TELEMETRY_EVENT_STRING(...) should be removed to avoid confusion. Either remove the formatting/commented line or rework telemetry to use the intended marker/value type.

                if(param->toPersist){
                    char telemetryValue[128] = {0};
                    snprintf(telemetryValue, sizeof(telemetryValue), "The HDMI Audio Mode Setting From Persistent is %d", param->toPersist);
                    // TELEMETRY_EVENT_STRING("SYS_INFO_Userpassthruenable_split", telemetryValue);
                    TELEMETRY_EVENT_INT("SYS_INFO_Userpassthruenable", 1);

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.