Skip to content

RDKEMW-18673 - edidIGNORE Fallback#246

Open
hgfell683 wants to merge 1 commit into
developfrom
feature/RDKEMW-18673
Open

RDKEMW-18673 - edidIGNORE Fallback#246
hgfell683 wants to merge 1 commit into
developfrom
feature/RDKEMW-18673

Conversation

@hgfell683
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 18, 2026 13:58
@hgfell683 hgfell683 requested a review from a team as a code owner May 18, 2026 13:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the video port RPC service to make dsGetIgnoreEDIDStatus more resilient by applying a fallback behavior when the underlying HAL call fails.

Changes:

  • Capture dsGetIgnoreEDIDStatus return code and detect HAL failures.
  • On HAL error, log the failure and force ignoreEDID = true as a fallback.
Comments suppressed due to low confidence (1)

rpc/srv/dsVideoPort.c:2336

  • param->ignoreEDID is not explicitly initialized in this handler (despite the “Default status is false” comment). If this IARM call is invoked with a non-zeroed dsEdidIgnoreParam_t, the function can return a stale/undefined ignoreEDID value when func is NULL or before the HAL writes it. Consider setting param->ignoreEDID = false before attempting the HAL call (and/or in an else branch when func is NULL) so the output is deterministic.
    dsEdidIgnoreParam_t *param = (dsEdidIgnoreParam_t*) arg;
    dsError_t ret = dsERR_GENERAL;
    _DEBUG_ENTER();
    IARM_BUS_Lock(lock);
    //Default status is false
    typedef dsError_t (*dsGetIgnoreEDIDStatus_t)(intptr_t handleArg, bool* statusArg);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rpc/srv/dsVideoPort.c
Comment on lines +2355 to +2360
if (func != NULL) {
ret = func(param->handle, &param->ignoreEDID);
if (ret != dsERR_NONE) {
INT_INFO("dsSRV: dsGetIgnoreEDIDStatus failed with err:%d, falling back ignoreEDID to true\r\n", ret);
param->ignoreEDID = true;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants