RDKEMW-18673 - edidIGNORE Fallback#246
Open
hgfell683 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the video port RPC service to make dsGetIgnoreEDIDStatus more resilient by applying a fallback behavior when the underlying HAL call fails.
Changes:
- Capture
dsGetIgnoreEDIDStatusreturn code and detect HAL failures. - On HAL error, log the failure and force
ignoreEDID = trueas a fallback.
Comments suppressed due to low confidence (1)
rpc/srv/dsVideoPort.c:2336
param->ignoreEDIDis not explicitly initialized in this handler (despite the “Default status is false” comment). If this IARM call is invoked with a non-zeroeddsEdidIgnoreParam_t, the function can return a stale/undefinedignoreEDIDvalue whenfuncis NULL or before the HAL writes it. Consider settingparam->ignoreEDID = falsebefore attempting the HAL call (and/or in anelsebranch whenfuncis NULL) so the output is deterministic.
dsEdidIgnoreParam_t *param = (dsEdidIgnoreParam_t*) arg;
dsError_t ret = dsERR_GENERAL;
_DEBUG_ENTER();
IARM_BUS_Lock(lock);
//Default status is false
typedef dsError_t (*dsGetIgnoreEDIDStatus_t)(intptr_t handleArg, bool* statusArg);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2355
to
+2360
| if (func != NULL) { | ||
| ret = func(param->handle, ¶m->ignoreEDID); | ||
| if (ret != dsERR_NONE) { | ||
| INT_INFO("dsSRV: dsGetIgnoreEDIDStatus failed with err:%d, falling back ignoreEDID to true\r\n", ret); | ||
| param->ignoreEDID = true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.