RDKEMW-11398: Establish HdmiCecSink<--->UserSettings#403
RDKEMW-11398: Establish HdmiCecSink<--->UserSettings#403yeshwanth-nagaswamy wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR, titled “RDKEMW-11398: Establish HdmiCecSink<--->UserSettings”, currently updates the HDMI CEC L2 test helper logging around file deletion failures.
Changes:
- Adds an additional
printfline whenstd::removefails inremoveFile().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (std::remove(fileName) != 0) | ||
| { | ||
| printf("File %s failed to remove\n", fileName); | ||
| printf("File %s failed to remove\n", fileName); |
There was a problem hiding this comment.
There are two identical printf("File %s failed to remove\n", fileName); lines here, which will duplicate the log output on failure. Remove the duplicate (or replace one with additional context if intended).
| printf("File %s failed to remove\n", fileName); |
| printf("File %s failed to remove\n", fileName); | ||
| printf("File %s failed to remove\n", fileName); |
There was a problem hiding this comment.
The PR title mentions establishing "HdmiCecSink<--->UserSettings", but this change only adds an extra log line in the HdmiCecSource L2 test helper. Either update the PR title/description to match the actual change, or include the intended functional changes for HdmiCecSink/UserSettings integration in this PR.
No description provided.