Feature/test pr 1 by DakshayaniMV · Pull Request #409 · rdkcentral/entservices-inputoutput

DakshayaniMV · 2026-05-20T14:22:47Z

No description provided.

* RDKEMW-10804: reduce logs for hdmicec componeent Signed-off-by: apatel859 <Amit_Patel5@comcast.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>

…Apple TV via HDMI (CEC FeatureAbort: CEC Version) (#401) * RDKEMW-16812 : [EntOS] [A4K] Mute Fails During YouTube Playback with Apple TV via HDMI (CEC FeatureAbort: CEC Version) * Address copilot review comments

* RDKEMW-11398: Implement HdmiCecSink & UserSettings communication * Update HdmiCecSink.cpp

Copilot

Pull request overview

This PR updates the HDMI CEC plugins by removing verbose header-print logging, adding JSON-RPC notifications for received CEC user-control key events, and integrating with the UserSettings plugin to track presentation-language changes and send SetMenuLanguage.

Changes:

Remove printHeader() debug logging from HdmiCec Source/Sink message processors.
Add CEC UserControlPressed/Released handling in HdmiCecSink and emit new JSON-RPC notifications (onKeyPressEvent / onKeyReleaseEvent).
Integrate HdmiCecSink with org.rdk.UserSettings to fetch/track presentation language and map BCP47 → ISO-639-2.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Tests/L2Tests/tests/AVOutputTV_L2Test.cpp	Minor comment tweak in the L2 test file.
HdmiCecSource/HdmiCecSourceImplementation.h	Removes inline `printHeader()` helper.
HdmiCecSource/HdmiCecSourceImplementation.cpp	Removes `printHeader()` calls from message processing.
HdmiCecSink/HdmiCecSink.h	Adds IUserSettings integration types, new processor handlers, and helper declarations.
HdmiCecSink/HdmiCecSink.cpp	Adds new events + notifications, UserSettings initialization/uninitialization, language mapping, and key press/release wrappers.

Comments suppressed due to low confidence (2)

HdmiCecSink/HdmiCecSink.cpp:960

onPresentationLanguageChanged() also uses isoLang.data() when constructing Language. Since this project builds with C++11, data() is not guaranteed to be null-terminated; use c_str() to avoid undefined behavior.

	   string isoLang = mapToIso639_2(presentationLanguage);
	   LOGINFO("OnPresentationLanguageChanged - language BCP47: %s, ISO 639-2: %s", presentationLanguage.c_str(), isoLang.c_str());
	   setCurrentLanguage(Language(isoLang.data()));
           sendMenuLanguage();

HdmiCecSink/HdmiCecSink.cpp:2833

After logical-address allocation, m_currentLanguage is no longer initialized (previous default "eng" assignment was removed). CECDeviceParams defaults this to an empty Language, so sendMenuLanguage()/SetMenuLanguage may transmit an invalid/empty language unless an external call sets it. Please set a sensible default (e.g., "eng") here, or apply the cached UserSettings language once allocation succeeds.

                            			_instance->deviceList[_instance->m_logicalAddressAllocated].update(physical_addr);
						    _instance->deviceList[_instance->m_logicalAddressAllocated].m_cecVersion = Version::V_1_4;
						    _instance->deviceList[_instance->m_logicalAddressAllocated].m_vendorID = appVendorId;
						    _instance->deviceList[_instance->m_logicalAddressAllocated].m_powerStatus = PowerStatus(powerState);
						    _instance->deviceList[_instance->m_logicalAddressAllocated].m_osdName = osdName.toString().c_str();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                   if (status == Core::ERROR_NONE) {
+					   isoLang = mapToIso639_2(presentationLanguage);
+					   LOGINFO("Successfully retrieved the Presentation language from the userSettings plugin - BCP47: %s, ISO 639-2: %s", presentationLanguage.c_str(), isoLang.c_str());
+					   setCurrentLanguage(Language(isoLang.data()));
+					   sendMenuLanguage();


+                   if (status == Core::ERROR_NONE) {
+					   isoLang = mapToIso639_2(presentationLanguage);
+					   LOGINFO("Successfully retrieved the Presentation language from the userSettings plugin - BCP47: %s, ISO 639-2: %s", presentationLanguage.c_str(), isoLang.c_str());
+					   setCurrentLanguage(Language(isoLang.data()));


+               std::transform(lang.begin(), lang.end(), lang.begin(), ::tolower);
+
+               if (lang.length() == 3)
+		       return lang;
+
+	       static const std::unordered_map<std::string, std::string> iso639_1_to_2 = {


+	}
+
    } // namespace Plugin
 } // namespace WPEFrameworklk


rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:900

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Uninitialized scalar field

Non-static class member "m_isRequested" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.h:161

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.h:282

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Uninitialized pointer field

Non-static class member "msgFrameListener" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:672

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Variable copied when it could be moved

"addr" is copied in call to copy assignment for class "LogicalAddress", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""addr"")" instead of "addr".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.cpp:1161

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Check of thread-shared field evades lock acquisition

Thread1 sets "m_currentArcRoutingState" to a new value. Now the two threads have an inconsistent view of "m_currentArcRoutingState" and updates to fields correlated with "m_currentArcRoutingState" may be lost.

High Impact, CWE-543
LOCK_EVASION

How to fix

Guard the modification of "m_currentArcRoutingState" and the read used to decide whether to modify "m_currentArcRoutingState" with the same set of locks.

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:1049

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Dereference after null check

Dereferencing null pointer "WPEFramework::Plugin::HdmiCecSourceImplementation::_instance".

Medium Impact, CWE-476
FORWARD_NULL

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.cpp:739

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "hdmiPort". Field "hdmiPort.m_logicalAddr.impl" is uninitialized when calling "push_back". [Note: The source code implementation of the function has been overridden by a builtin model.]

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:785

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.cpp:707

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Variable copied when it could be moved

"logicalAddrDeviceType" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""logicalAddrDeviceType"")" instead of "logicalAddrDeviceType".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.cpp:1162

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Variable copied when it could be moved

"hdmiPort" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::push_back(std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::value_type const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""hdmiPort"")" instead of "hdmiPort".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:785

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Uninitialized pointer field

Non-static class member "msgFrameListener" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSource/HdmiCecSourceImplementation.cpp:352

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Waiting while holding a lock

Call to "usleep" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:3153

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.h:735

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Variable copied when it could be moved

"audiodescriptor" is passed-by-value as parameter to "WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant::ArrayType(WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""audiodescriptor"")" instead of "audiodescriptor".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:1111

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Data race condition

A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. [Note: The source code implementation of the function has been overridden by a builtin model.]

Medium Impact, CWE-none
BAD_CHECK_OF_WAIT_COND

How to fix

Check the wait condition in a loop, with the lock held. The lock must not be released between the condition and the wait.

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:3013

rdkcmf-jenkins · 2026-05-20T14:38:12Z

Coverity Issue - Dereference before null check

Null-checking "this->smConnection" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
HdmiCecSink/HdmiCecSink.cpp:3121

hgfell683 and others added 4 commits February 23, 2026 15:06

RDKEMW:10804 reduce hdmicec plugin logs new (#340) (#386)

ce31d91

* RDKEMW-10804: reduce logs for hdmicec componeent Signed-off-by: apatel859 <Amit_Patel5@comcast.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>

Topic/rdkemw11398 (#405)

72f8a74

* RDKEMW-11398: Implement HdmiCecSink & UserSettings communication * Update HdmiCecSink.cpp

Sample PR test

4e12f0b

Copilot AI review requested due to automatic review settings May 20, 2026 14:22

Copilot started reviewing on behalf of DakshayaniMV May 20, 2026 14:23 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Conversation

DakshayaniMV commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Parse warning

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Uninitialized scalar field

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Parse warning

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Uninitialized pointer field

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Check of thread-shared field evades lock acquisition

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Dereference after null check

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Uninitialized scalar variable

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Parse warning

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Uninitialized pointer field

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Waiting while holding a lock

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Parse warning

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Variable copied when it could be moved

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Data race condition

How to fix

Issue location

Uh oh!

rdkcmf-jenkins commented May 20, 2026

Coverity Issue - Dereference before null check