RDKEMW-16743: Create common helpers library#19
Open
preeja33 wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test build configuration to consume a newly introduced “common helpers” header location from the install prefix, rather than referencing multiple per-component helper directories.
Changes:
- Switched MockAccessor and L2Tests plugin include paths from source-tree helper paths to
${CMAKE_INSTALL_PREFIX}/include/wpeframework/helpers. - Simplified the L2Tests plugin helper include setup by collapsing the previous multi-path
ENTSERVICES_INCinto a single common helpers include root.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tests/mocks/CMakeLists.txt | Updates MockAccessor include dirs to use the installed common helpers headers path. |
| Tests/L2Tests/L2TestsPlugin/CMakeLists.txt | Replaces multi-repo helper include list with the installed common helpers include path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| set(ENTSERVICES_INC ${CMAKE_INSTALL_PREFIX}/include/wpeframework/helpers) | ||
|
|
||
| target_include_directories(${MODULE_NAME} PRIVATE ../../../helpers) | ||
| target_include_directories(${MODULE_NAME} PRIVATE ${CMAKE_INSTALL_PREFIX}/include/wpeframework/helpers) |
Comment on lines
102
to
103
| set(ENTSERVICES_INC ${CMAKE_INSTALL_PREFIX}/include/wpeframework/helpers) | ||
|
|
Comment on lines
101
to
+102
| set(ENTSERVICES_INC ../../../../entservices-deviceanddisplay/helpers ../../../../entservices-infra/helpers ../../../../entservices-mediaanddrm/helpers ../../../../entservices-softwareupdate/helpers ../../../../entservices-inputoutput/helpers ../../../../entservices-peripherals/helpers ../../../../entservices-connectivity/helpers) | ||
| set(ENTSERVICES_INC ../../../../entservices-helpers/helpers) |
| target_link_libraries(${MODULE_NAME} PRIVATE ${NAMESPACE}Plugins::${NAMESPACE}Plugins gtest_main gmock gtest) | ||
|
|
||
| set(ENTSERVICES_INC ../../../../entservices-deviceanddisplay/helpers ../../../../entservices-infra/helpers ../../../../entservices-mediaanddrm/helpers ../../../../entservices-softwareupdate/helpers ../../../../entservices-inputoutput/helpers ../../../../entservices-peripherals/helpers ../../../../entservices-connectivity/helpers) | ||
| set(ENTSERVICES_INC ../../../../entservices-helpers/helpers) |
|
|
||
| # Include directories | ||
| target_include_directories(${MODULE_NAME} PRIVATE ${IARMBUS_INCLUDE_DIRS} ../../../helpers ../../mocks) | ||
| target_include_directories(${MODULE_NAME} PRIVATE ${IARMBUS_INCLUDE_DIRS} ../../../entservices-helpers/helpers ../../mocks) |
Comment on lines
101
to
+102
| set(ENTSERVICES_INC ../../../../entservices-deviceanddisplay/helpers ../../../../entservices-infra/helpers ../../../../entservices-mediaanddrm/helpers ../../../../entservices-softwareupdate/helpers ../../../../entservices-inputoutput/helpers ../../../../entservices-peripherals/helpers ../../../../entservices-connectivity/helpers) | ||
| set(ENTSERVICES_INC ../../../../entservices-helpers/helpers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Create common helpers library
Test Procedure: check the ticket
Risks: Medium
Priority: P1
version: Patch