RDKEMW-18857 : Remove RDKCM_RDKE from all workflows#25
Open
balav08 wants to merge 4 commits into
Open
Conversation
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private .Now repo has been made as public.so removing the RDKCM_RDKE secrets. Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the RDKCM_RDKE secret from GitHub workflows, aligning CI/release automation with the repository now being public and no longer requiring that credential for access.
Changes:
- Removed
RDKCM_RDKEsecret passing from reusable-workflow triggers (tf-trigger*.yml). - Updated the component release workflow to clone the repo without using the
RDKCM_RDKEtoken.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/tf-trigger.yml | Stops passing RDKCM_RDKE into many reusable workflow calls. |
| .github/workflows/tf-trigger-2.yml | Stops passing RDKCM_RDKE into additional reusable workflow calls. |
| .github/workflows/component-release.yml | Removes token-based clone URL for the release workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
38
| - name: Clone the project and start release | ||
| run: | | ||
| set -e | ||
| git clone https://x-access-token:${{ secrets.RDKCM_RDKE }}@github.com/${{ github.repository }} project | ||
| git clone https://github.com/${{ github.repository }} project | ||
| cd project |
| run: | | ||
| set -e | ||
| git clone https://x-access-token:${{ secrets.RDKCM_RDKE }}@github.com/${{ github.repository }} project | ||
| git clone https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }} project |
| set -e | ||
| git clone https://x-access-token:${{ secrets.RDKCM_RDKE }}@github.com/${{ github.repository }} project | ||
| git clone https://github.com/${{ github.repository }} project | ||
| cd project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private .Now repo has been made as public.so removing the RDKCM_RDKE secrets.
Test Procedure: refer ticket.
Risks: Medium
Priority: P2
version: Patch