RDKEMW-16053 : Implement L1/L2 test cases for SystemServices plugin.#28
Open
balav08 wants to merge 6 commits into
Open
RDKEMW-16053 : Implement L1/L2 test cases for SystemServices plugin.#28balav08 wants to merge 6 commits into
balav08 wants to merge 6 commits into
Conversation
Update to latest.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the test framework’s IARM bus mock to support additional bus lifecycle operations needed by the new SystemServices L1/L2 test cases.
Changes:
- Added
IARM_Bus_Disconnect()andIARM_Bus_Term()wrappers toTests/mocks/Iarm.cppthat forward calls to the active mock implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+51
to
+64
| IARM_Result_t IarmBus::IARM_Bus_Disconnect() | ||
| { | ||
| TEST_LOG("Inside IARM_Bus_Disconnect"); | ||
| EXPECT_NE(impl, nullptr); | ||
| return impl->IARM_Bus_Disconnect(); | ||
| } | ||
|
|
||
| IARM_Result_t IarmBus::IARM_Bus_Term() | ||
| { | ||
| TEST_LOG("Inside IARM_Bus_Term"); | ||
| EXPECT_NE(impl, nullptr); | ||
| return impl->IARM_Bus_Term(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Tests/mocks/Iarm.cpp:63
IarmBus::IARM_Bus_Term()is defined twice in this translation unit (another definition exists later in the file). This will cause a redefinition/duplicate symbol compile error; remove one of the definitions and keep a single implementation.
IARM_Result_t IarmBus::IARM_Bus_Term()
{
TEST_LOG("Inside IARM_Bus_Term");
EXPECT_NE(impl, nullptr);
return impl->IARM_Bus_Term();
}
Comment on lines
+51
to
+64
| IARM_Result_t IarmBus::IARM_Bus_Disconnect() | ||
| { | ||
| TEST_LOG("Inside IARM_Bus_Disconnect"); | ||
| EXPECT_NE(impl, nullptr); | ||
| return impl->IARM_Bus_Disconnect(); | ||
| } | ||
|
|
||
| IARM_Result_t IarmBus::IARM_Bus_Term() | ||
| { | ||
| TEST_LOG("Inside IARM_Bus_Term"); | ||
| EXPECT_NE(impl, nullptr); | ||
| return impl->IARM_Bus_Term(); | ||
| } | ||
|
|
Comment on lines
102
to
+103
| set(ENTSERVICES_INC ../../../../entservices-deviceanddisplay/helpers ../../../../entservices-infra/helpers ../../../../entservices-mediaanddrm/helpers ../../../../entservices-softwareupdate/helpers ../../../../entservices-inputoutput/helpers ../../../../entservices-peripherals/helpers ../../../../entservices-connectivity/helpers) | ||
| set(ENTSERVICES_INC ../../../../entservices-helpers/helpers) |
| target_link_libraries(${MODULE_NAME} PRIVATE ${NAMESPACE}Plugins::${NAMESPACE}Plugins gtest_main gmock gtest) | ||
|
|
||
| set(ENTSERVICES_INC ../../../../entservices-deviceanddisplay/helpers ../../../../entservices-infra/helpers ../../../../entservices-mediaanddrm/helpers ../../../../entservices-softwareupdate/helpers ../../../../entservices-inputoutput/helpers ../../../../entservices-peripherals/helpers ../../../../entservices-connectivity/helpers) | ||
| set(ENTSERVICES_INC ../../../../entservices-helpers/helpers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.