Skip to content

RDKEMW-15868 : LinchpinClientProxy thunder plug-in#31

Merged
hgfell683 merged 21 commits into
developfrom
feature/LinchpinBroker
Jun 2, 2026
Merged

RDKEMW-15868 : LinchpinClientProxy thunder plug-in#31
hgfell683 merged 21 commits into
developfrom
feature/LinchpinBroker

Conversation

@pahearn73
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 1, 2026 12:00
@pahearn73 pahearn73 requested a review from a team as a code owner June 1, 2026 12:00
@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Copyright scan failure
Commit: 032a275
Report detail: https://gist.github.com/rdkcmf-jenkins/38bd72aa470ec8fa169d8a6a3cc25242'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 032a275

Report detail: gist'

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces test-time replacements needed to build and unit-test the LinchpinClientProxy Thunder plugin in this test framework by providing a mockable LinchpinService interface/wrapper and vendored CivetWeb headers/stubs, plus build-system wiring for L1/L2 tests.

Changes:

  • Added a LinchpinService wrapper (Tests/mocks/LinchpinService.h/.cpp) and a gmock implementation (Tests/mocks/LinchpinServiceMock.h) for L1 tests.
  • Vendored CivetWeb “lite” header and added stub mg_* implementations under Tests/mocks/civetweb/.
  • Updated CMake to link in the new mocks and expose CivetWeb mock include paths to L1/L2 test targets.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 42 comments.

Show a summary per file
File Description
Tests/mocks/LinchpinServiceMock.h Adds a gmock implementation of the Linchpin service interface for L1 tests.
Tests/mocks/LinchpinService.h Adds a test wrapper/interface mirroring the real LinchpinService API.
Tests/mocks/LinchpinService.cpp Implements the wrapper by forwarding calls to a static impl pointer.
Tests/mocks/CMakeLists.txt Updates mock library sources/conditions to include new Linchpin mocks (and should include CivetWeb stubs).
Tests/mocks/civetweb/civetweb_lite.h Adds vendored CivetWeb header used to satisfy compile-time dependencies.
Tests/mocks/civetweb/civetweb_lite.cpp Adds stub implementations for CivetWeb mg_* symbols used by the plugin.
Tests/mocks/civetweb/as_civetweb.h Adds a small wrapper header to include config + civetweb header.
Tests/mocks/civetweb/as_civetweb_config.h Adds CivetWeb configuration header for the stubbed build.
Tests/L2Tests/L2TestsPlugin/CMakeLists.txt Adds CivetWeb mock include path for L2 tests plugin build.
Tests/L1Tests/CMakeLists.txt Adds CivetWeb mock include path and links CPC L1 test lib when LinchpinClientProxy is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Tests/mocks/LinchpinService.cpp
Comment thread Tests/mocks/LinchpinService.cpp
Comment thread Tests/mocks/LinchpinService.cpp
Comment thread Tests/mocks/LinchpinService.cpp
Comment thread Tests/mocks/LinchpinService.cpp
Comment thread Tests/mocks/civetweb/civetweb_lite.cpp Outdated
Comment thread Tests/mocks/civetweb/civetweb_lite.cpp Outdated
Comment thread Tests/mocks/CMakeLists.txt Outdated
Comment thread Tests/mocks/CMakeLists.txt
Comment thread Tests/mocks/civetweb/as_civetweb_config.h Outdated
@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 032a275

Report detail: gist'

Copy link
Copy Markdown

@mhughesacn mhughesacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pahearn73 : Some small changes please before I clear off the checks.
Thank you!

Comment thread Tests/mocks/civetweb/as_civetweb_config.h Outdated
Comment thread Tests/mocks/civetweb/civetweb_lite.h
Copilot AI review requested due to automatic review settings June 1, 2026 17:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment thread Tests/mocks/CMakeLists.txt
Comment thread Tests/mocks/LinchpinService.h
Comment thread Tests/mocks/LinchpinServiceMock.h Outdated
@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Copyright scan failure
Commit: 139649d
Report detail: https://gist.github.com/rdkcmf-jenkins/bb63d4379552225467eafdda692877c3'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 139649d

Report detail: gist'

Copilot AI review requested due to automatic review settings June 1, 2026 18:02
@pahearn73 pahearn73 force-pushed the feature/LinchpinBroker branch from 60deeae to 5b7d61e Compare June 1, 2026 18:03
@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Copyright scan failure
Commit: 60deeae
Report detail: https://gist.github.com/rdkcmf-jenkins/eb01875a8a7a9cba2b4ec88f471a5b1a'

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 5b7d61e

Report detail: gist'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Copyright scan failure
Commit: 5b7d61e
Report detail: https://gist.github.com/rdkcmf-jenkins/f71f8ef94b414d980b9059950ee9d511'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 5b7d61e

Report detail: gist'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Copyright scan failure
Commit: 0366697
Report detail: https://gist.github.com/rdkcmf-jenkins/8404225015ca3a1e9cb1750101f83ca1'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/entservices-testframework/31/rdkcentral/entservices-testframework

  • Commit: 0366697

Report detail: gist'

@rdkcmf-jenkins
Copy link
Copy Markdown

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Thank you

  • Commit: 0366697
    '

@pahearn73 pahearn73 requested review from anand-ky and srikanth-vv June 2, 2026 12:28
hgfell683
hgfell683 previously approved these changes Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comment thread Tests/mocks/CMakeLists.txt
Comment thread Tests/mocks/civetweb/as_civetweb.h
mhughesacn
mhughesacn previously approved these changes Jun 2, 2026
Copy link
Copy Markdown

@mhughesacn mhughesacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a compliance POV only.

@pahearn73 pahearn73 dismissed stale reviews from mhughesacn and hgfell683 via c0a0065 June 2, 2026 15:43
@pahearn73 pahearn73 force-pushed the feature/LinchpinBroker branch from 7488399 to c0a0065 Compare June 2, 2026 15:43
@hgfell683 hgfell683 merged commit 4f0f06c into develop Jun 2, 2026
23 of 28 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants