RDKEMW-15868 : LinchpinClientProxy thunder plug-in#31
Conversation
|
b'## Copyright scan failure |
There was a problem hiding this comment.
Pull request overview
This PR introduces test-time replacements needed to build and unit-test the LinchpinClientProxy Thunder plugin in this test framework by providing a mockable LinchpinService interface/wrapper and vendored CivetWeb headers/stubs, plus build-system wiring for L1/L2 tests.
Changes:
- Added a
LinchpinServicewrapper (Tests/mocks/LinchpinService.h/.cpp) and agmockimplementation (Tests/mocks/LinchpinServiceMock.h) for L1 tests. - Vendored CivetWeb “lite” header and added stub
mg_*implementations underTests/mocks/civetweb/. - Updated CMake to link in the new mocks and expose CivetWeb mock include paths to L1/L2 test targets.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 42 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/mocks/LinchpinServiceMock.h | Adds a gmock implementation of the Linchpin service interface for L1 tests. |
| Tests/mocks/LinchpinService.h | Adds a test wrapper/interface mirroring the real LinchpinService API. |
| Tests/mocks/LinchpinService.cpp | Implements the wrapper by forwarding calls to a static impl pointer. |
| Tests/mocks/CMakeLists.txt | Updates mock library sources/conditions to include new Linchpin mocks (and should include CivetWeb stubs). |
| Tests/mocks/civetweb/civetweb_lite.h | Adds vendored CivetWeb header used to satisfy compile-time dependencies. |
| Tests/mocks/civetweb/civetweb_lite.cpp | Adds stub implementations for CivetWeb mg_* symbols used by the plugin. |
| Tests/mocks/civetweb/as_civetweb.h | Adds a small wrapper header to include config + civetweb header. |
| Tests/mocks/civetweb/as_civetweb_config.h | Adds CivetWeb configuration header for the stubbed build. |
| Tests/L2Tests/L2TestsPlugin/CMakeLists.txt | Adds CivetWeb mock include path for L2 tests plugin build. |
| Tests/L1Tests/CMakeLists.txt | Adds CivetWeb mock include path and links CPC L1 test lib when LinchpinClientProxy is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mhughesacn
left a comment
There was a problem hiding this comment.
Hi @pahearn73 : Some small changes please before I clear off the checks.
Thank you!
|
b'## Copyright scan failure |
60deeae to
5b7d61e
Compare
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
mhughesacn
left a comment
There was a problem hiding this comment.
Approving from a compliance POV only.
7488399 to
c0a0065
Compare
No description provided.