RDKEMW-13483: Integrate entservices-UserSettings into middleware builds by agampa263 · Pull Request #1 · rdkcentral/entservices-usersettings

agampa263 · 2026-02-13T11:17:37Z

No description provided.

Copilot

Pull request overview

Updates the repository/build configuration to target the entservices-usersettings component (instead of entservices-infra), adjusting CI and scripts accordingly, and removes a large set of legacy helper utilities and CMake find modules.

Changes:

Renames CI checkout/build paths and artifacts from entservices-infra to entservices-usersettings across workflows and Coverity build script.
Simplifies top-level build to only add the UserSettings subdirectory.
Deletes numerous helper headers/WebSockets helpers and many custom cmake/Find*.cmake modules.

Reviewed changes

Copilot reviewed 89 out of 89 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
services.cmake	Removes several plugin options/definitions; adjusts ContinueWatching defines.
helpers/tptimer.h	Deleted legacy helper.
helpers/frontpanel.h	Deleted legacy helper.
helpers/cSettings.h	Deleted legacy helper.
helpers/WebSockets/WSEndpoint.h	Deleted legacy WebSockets helper.
helpers/WebSockets/WSEndpoint.cpp	Deleted legacy WebSockets helper.
helpers/WebSockets/Roles/SingleClientServer.h	Deleted legacy WebSockets helper.
helpers/WebSockets/Roles/Client.h	Deleted legacy WebSockets helper.
helpers/WebSockets/PingPong/PingPongEnabled.h	Deleted legacy WebSockets helper.
helpers/WebSockets/PingPong/PingPongDisabled.h	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Response.h	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Response.cpp	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Request.h	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Request.cpp	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Notification.h	Deleted legacy WebSockets helper.
helpers/WebSockets/JsonRpc/Notification.cpp	Deleted legacy WebSockets helper.
helpers/WebSockets/Encryption/TlsEnabled.h	Deleted legacy WebSockets helper.
helpers/WebSockets/Encryption/NoEncryption.h	Deleted legacy WebSockets helper.
helpers/WebSockets/CommunicationInterface/JsonRpcInterface.h	Deleted legacy WebSockets helper.
helpers/WebSockets/CommunicationInterface/CommandInterface.h	Deleted legacy WebSockets helper.
helpers/WebSockets/CommunicationInterface/BinaryInterface.h	Deleted legacy WebSockets helper.
helpers/UtilssyncPersistFile.h	Deleted legacy helper.
helpers/UtilsisValidInt.h	Deleted legacy helper.
helpers/UtilsgetRFCConfig.h	Deleted legacy helper.
helpers/UtilsgetFileContent.h	Deleted legacy helper.
helpers/UtilsfileExists.h	Deleted legacy helper.
helpers/UtilsUnused.h	Deleted legacy helper.
helpers/UtilsUUID.h	Deleted legacy helper.
helpers/UtilsThreadRAII.h	Deleted legacy helper.
helpers/UtilsTelemetry.h	Deleted legacy helper.
helpers/UtilsSynchroIarm.hpp	Deleted legacy helper.
helpers/UtilsSynchro.hpp	Deleted legacy helper.
helpers/UtilsString.h	Deleted legacy helper.
helpers/UtilsSearchRDKProfile.h	Deleted legacy helper.
helpers/UtilsProcess.h	Deleted legacy helper.
helpers/UtilsLibraryLoader.h	Deleted legacy helper.
helpers/UtilsLOG_MILESTONE.h	Deleted legacy helper.
helpers/UtilsJsonrpcDirectLink.h	Deleted legacy helper.
helpers/UtilsInputValidator.h	Deleted legacy helper.
helpers/UtilsIarm.h	Deleted legacy helper.
helpers/UtilsFirebolt.h	Deleted legacy helper.
helpers/UtilsFile.h	Deleted legacy helper.
helpers/UtilsController.h	Deleted legacy helper.
helpers/UtilsConnections.h	Deleted legacy helper.
helpers/UtilsCallsign.h	Deleted legacy helper.
helpers/UtilsCStr.h	Deleted legacy helper.
helpers/UtilsBIT.h	Deleted legacy helper.
helpers/StringUtils.h	Deleted legacy helper.
helpers/StreamJSONOneShot.h	Deleted legacy helper.
helpers/PowerManagerInterface.h	Deleted legacy helper.
helpers/PluginInterfaceBuilder.h	Deleted legacy helper.
helpers/ObjectUtils.h	Deleted legacy helper.
helpers/ContextUtils.h	Deleted legacy helper.
helpers/BaseEventDelegate.h	Deleted legacy helper.
cov_build.sh	Renames build dir/labels to `entservices-usersettings`.
cmake/FindUdev.cmake	Deleted custom Find module.
cmake/FindTTS.cmake	Deleted custom Find module.
cmake/FindSqliteSee.cmake	Deleted custom Find module.
cmake/FindRDKStorageManager.cmake	Deleted custom Find module.
cmake/FindPlabels.cmake	Deleted custom Find module.
cmake/FindNopoll.cmake	Deleted custom Find module.
cmake/FindNXCLIENT.cmake	Deleted custom Find module.
cmake/FindNEXUS.cmake	Deleted custom Find module.
cmake/FindLibSoup.cmake	Deleted custom Find module.
cmake/FindLMPLAYER.cmake	Deleted custom Find module.
cmake/FindGStreamerVideo.cmake	Deleted custom Find module.
cmake/FindGStreamer.cmake	Deleted custom Find module.
cmake/FindGLIB.cmake	Deleted custom Find module.
cmake/FindDL.cmake	Deleted custom Find module.
cmake/FindCurl.cmake	Deleted custom Find module.
cmake/FindCTRLM.cmake	Deleted custom Find module.
cmake/FindCEC.cmake	Deleted custom Find module.
cmake/FindBCM_HOST.cmake	Deleted custom Find module.
cmake/FindAamp.cmake	Deleted custom Find module.
cmake/FindAC.cmake	Deleted custom Find module.
Tests/L1Tests/CMakeLists.txt	Updates include paths from `entservices-infra` to `entservices-usersettings`.
OCIContainer/CMakeLists.txt	Updates testframework mocks include path from `entservices-infra` to `entservices-usersettings`.
CMakeLists.txt	Removes conditional plugin subdirectories; always adds `UserSettings`.
.github/workflows/native_full_build.yml	Renames job labeling to `entservices-usersettings`.
.github/workflows/L2-tests.yml	Renames repo/paths to `entservices-usersettings` and removes deviceanddisplay checkout/build.
.github/workflows/L2-tests-oop.yml	Renames repo/paths to `entservices-usersettings`; sets `-DL2_TEST_OOP_RPC=ON`.
.github/workflows/L1-tests.yml	Renames repo/paths to `entservices-usersettings` and adjusts build flags/includes.
.github/instructions/Pluginimplementation.instructions.md	Updates instruction links to `entservices-usersettings` repo URLs.
.github/instructions/Plugin.instructions.md	Updates instruction links to `entservices-usersettings` repo URLs.
.github/copilot-instructions.md	Updates guidance links/examples to `entservices-usersettings` repo URLs.
.github/CODEOWNERS	Updates default codeowner team.

Copilot · 2026-02-13T11:25:10Z

 #add_definitions (-DHAS_API_TTSRESOURCESERVICE)
-add_definitions (-DPLUGIN_CONTINUEWATCHING)
-option(PLUGIN_CONTINUEWATCHING "PLUGIN_CONTINUEWATCHING" ON)
-
-if(PLUGIN_CONTINUEWATCHING)
-    if(CONTINUEWATCHING_DISABLE_SECAPI)
-        add_definitions (-DDISABLE_SECAPI)
-    endif()
-endif()

+add_definitions (-DPLUGIN_CONTINUEWATCHING)

 if(PLUGIN_CONTINUEWATCHING)


add_definitions(-DPLUGIN_CONTINUEWATCHING) is now unconditional, which means the compile-time macro is defined even when PLUGIN_CONTINUEWATCHING is OFF. This can cause mismatches where code is compiled as-if the plugin/feature is enabled even though the build option is disabled. Consider moving this definition inside the existing if(PLUGIN_CONTINUEWATCHING) block (or removing it if it’s no longer used).

Copilot · 2026-02-13T11:25:10Z

+set (USBDEVICE_INC ${CMAKE_SOURCE_DIR}/../entservices-usersettings/USBDevice ${CMAKE_SOURCE_DIR}/../entservices-usersettings/helpers)
 set (USBDEVICE_LIBS ${NAMESPACE}USBDevice ${NAMESPACE}USBDeviceImplementation)
 add_plugin_test_ex(PLUGIN_USBDEVICE tests/test_USBDevice.cpp "${USBDEVICE_INC}" "${USBDEVICE_LIBS}")


The include paths hardcode the checkout directory name (../entservices-usersettings/...). This only works if the source tree is checked out into a folder named exactly entservices-usersettings, and breaks for local builds or when used as a subproject. Prefer ${CMAKE_SOURCE_DIR}/USBDevice and ${CMAKE_SOURCE_DIR}/helpers (or PROJECT_SOURCE_DIR) to make the build location-independent.

Copilot · 2026-02-13T11:25:11Z

-          -DCMAKE_TOOLCHAIN_FILE="${{ env.TOOLCHAIN_FILE }}"
+          -S "$GITHUB_WORKSPACE/entservices-usersettings"
+          -B build/entservices-usersettings
+          # -DCMAKE_TOOLCHAIN_FILE="${{ env.TOOLCHAIN_FILE }}"


The build step switches to the entservices-usersettings checkout/build dir, but the same step later still enables many plugin flags (USBDevice, USBMassStorage, OCIContainer, Telemetry, etc.). With the current root CMakeLists.txt only adding the UserSettings subdirectory, those plugin targets won’t be built and the L2Tests selection/linking based on these flags is likely to fail. Align CI flags with what the repo builds, or restore conditional add_subdirectory() for the enabled plugins.

Suggested change

# -DCMAKE_TOOLCHAIN_FILE="${{ env.TOOLCHAIN_FILE }}"

Copilot · 2026-02-13T11:25:11Z

 # PLUGIN_USBDEVICE
-set (USBDEVICE_INC ${CMAKE_SOURCE_DIR}/../entservices-infra/USBDevice ${CMAKE_SOURCE_DIR}/../entservices-infra/helpers)
+set (USBDEVICE_INC ${CMAKE_SOURCE_DIR}/../entservices-usersettings/USBDevice ${CMAKE_SOURCE_DIR}/../entservices-usersettings/helpers)
 set (USBDEVICE_LIBS ${NAMESPACE}USBDevice ${NAMESPACE}USBDeviceImplementation)
 add_plugin_test_ex(PLUGIN_USBDEVICE tests/test_USBDevice.cpp "${USBDEVICE_INC}" "${USBDEVICE_LIBS}")


This L1Tests target still includes tests/test_UtilsFile.cpp, which includes "UtilsFile.h". Since helpers/UtilsFile.h is removed in this PR, the L1Tests build will fail unless the test is updated to use an alternative implementation or the helper header is kept/moved. Please reconcile the helper deletions with the unit tests that depend on them.

Copilot · 2026-02-13T11:25:11Z

    add_definitions(-DDISABLE_SECURITY_TOKEN)
 endif()

-if(PLUGIN_USERSETTINGS)
-    add_subdirectory(UserSettings)
-endif()
-
-if(PLUGIN_USB_MASS_STORAGE)
-    add_subdirectory(USBMassStorage)
-endif()
-
-if(PLUGIN_OCICONTAINER)
-    add_subdirectory(OCIContainer)
-endif()
-
-if(PLUGIN_PERSISTENTSTORE)
-    add_subdirectory(PersistentStore)
-endif()
-
-if(PLUGIN_USBDEVICE)
-    add_subdirectory(USBDevice)
-endif()
-
-if(PLUGIN_TELEMETRY)
-    add_subdirectory(Telemetry)
-endif()
-
-if(PLUGIN_MONITOR)
-    add_subdirectory(Monitor)
-endif()
-
-if(PLUGIN_RDKSHELL)
-    add_subdirectory(RDKShell)
-endif()
-
-if(PLUGIN_RUSTADAPTER)
-    add_subdirectory(RustAdapter)
-endif()
-
-if(PLUGIN_MESSAGECONTROL)
-    add_subdirectory(MessageControl)
-endif()
+add_subdirectory(UserSettings)



add_subdirectory(UserSettings) is now unconditional, so cache flags like -DPLUGIN_USERSETTINGS=OFF (and other plugin flags) no longer control what gets built. This also breaks CI/scripts that still enable other plugins/tests, because the corresponding plugin targets (e.g., ${NAMESPACE}USBDevice) won’t be created. Consider restoring the previous if(PLUGIN_...) add_subdirectory(...) gating (at least for plugins enabled in CI) or, if the repo is intended to build only UserSettings, remove the unused plugin flags/tests/scripts accordingly to keep configuration consistent.

Copilot · 2026-02-13T11:25:11Z

+# Build entservices-usersettings
+echo "buliding entservices-usersettings"

 cd ${GITHUB_WORKSPACE}
-cmake -G Ninja -S "$GITHUB_WORKSPACE" -B build/entservices-infra \
+cmake -G Ninja -S "$GITHUB_WORKSPACE" -B build/entservices-usersettings \
 -DUSE_THUNDER_R4=ON \
 -DCMAKE_INSTALL_PREFIX="$GITHUB_WORKSPACE/install/usr" \


After switching the build directory/name to entservices-usersettings, this script still configures Coverity builds with multiple plugin flags and RDK_SERVICES_L1_TEST=ON. With the current root CMake only adding UserSettings, the L1Tests configuration can fail because plugin targets for the enabled flags won’t be created. Align this script with the set of plugins actually built (or restore conditional add_subdirectory() for the enabled plugins).

Copilot · 2026-02-13T11:25:12Z

-echo "buliding entservices-infra"
+
+# Build entservices-usersettings
+echo "buliding entservices-usersettings"


Typo in the log message: "buliding" → "building". This shows up in CI logs and can make searching for build steps harder.

Copilot

Pull request overview

Copilot reviewed 123 out of 525 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-16T12:35:39Z

+option(PLUGIN_USERSETTINGS "Include UserSettings plugin" ON)
+if(PLUGIN_USERSETTINGS)
+    add_subdirectory(UserSettings)
 endif()




The PLUGIN_USERSETTINGS option is duplicated on lines 40 and 44. Since this is now a dedicated UserSettings repository, the option declaration is redundant on line 44. Remove the duplicate option declaration.

Suggested change

option(PLUGIN_USERSETTINGS "Include UserSettings plugin" ON)

if(PLUGIN_USERSETTINGS)

add_subdirectory(UserSettings)

endif()

Copilot · 2026-02-16T12:35:40Z


      - name: Run unit tests with valgrind
-        if: ${{ !env.ACT }}
+        # if: ${{ !env.ACT }}


The valgrind test step has been commented out instead of properly handling the conditional. Either remove the commented condition entirely or restore it with proper justification. Commented-out conditions reduce code clarity.

Suggested change

# if: ${{ !env.ACT }}

if: ${{ !env.ACT }}

Copilot · 2026-02-16T12:35:40Z


      - name: Upload artifacts
-        if: ${{ !env.ACT }}
+        # if: ${{ !env.ACT }}


The artifact upload step has been commented out instead of properly handling the conditional. Either remove the commented condition entirely or restore it with proper justification. Leaving commented conditions in workflows can lead to confusion.

Suggested change

# if: ${{ !env.ACT }}

Copilot

Pull request overview

Copilot reviewed 123 out of 532 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-16T13:39:35Z


      - name: Upload artifacts
-        if: ${{ !env.ACT }}
+        # if: ${{ !env.ACT }}


Similar to the valgrind step, the artifacts upload condition is commented out, so artifacts will always upload. If this is unintentional (e.g., to avoid uploads during ACT/local runs), reintroduce the if: condition as an actual YAML field; otherwise, please remove the commented if: line to prevent confusion.

Suggested change

# if: ${{ !env.ACT }}

if: ${{ !env.ACT }}

Copilot · 2026-02-16T13:39:36Z

 ### Example

-Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-infra/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )
+Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-usersettings/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )


This example link appears to reference Telemetry/TelemetryImplementation.cpp inside entservices-usersettings, but this repository is being reduced to only UserSettings (Telemetry is not expected to live here). Update the reference to a stable location where the Telemetry example actually exists (e.g., the repo that owns Telemetry), or replace it with an in-repo example to avoid a dead/404 link.

Suggested change

Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-usersettings/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )

Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-infra/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )

Copilot

Pull request overview

Copilot reviewed 124 out of 527 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-17T03:10:18Z

      - name: Run unit tests with valgrind
-        if: ${{ !env.ACT }}
+        # if: ${{ !env.ACT }}
        run: >


Commenting out the if: key changes the step semantics (it will always run), which can unexpectedly run valgrind in environments where it was previously gated (e.g., local ACT runs). Restore a real if: condition (or remove the gating entirely, but as an intentional YAML key) rather than commenting it out.

Copilot · 2026-02-17T03:10:19Z

      - name: Upload artifacts
-        if: ${{ !env.ACT }}
+        # if: ${{ !env.ACT }}
        uses: actions/upload-artifact@v4


Same issue as above: commenting out if: makes artifact upload unconditional, which can produce noisy artifacts and slow down local/ACT runs. Reintroduce the if: condition as a YAML key (or explicitly decide to run always and remove the commented line).

Copilot

Pull request overview

Copilot reviewed 127 out of 528 changed files in this pull request and generated 5 comments.

Copilot · 2026-02-17T05:54:27Z

-
-if(PLUGIN_FBSETTINGS)
-	add_subdirectory(FbSettings)
+    add_subdirectory(plugin)


The hardcoded subdirectory name 'plugin' is unclear and doesn't follow the pattern of other plugin references. Consider using a more descriptive name like 'UserSettings' or define it as a variable (e.g., PLUGIN_USERSETTINGS_DIR) to maintain consistency with the conditional plugin pattern used elsewhere in RDK services.

Suggested change

add_subdirectory(plugin)

set(PLUGIN_USERSETTINGS_DIR "plugin")

add_subdirectory(${PLUGIN_USERSETTINGS_DIR})

Copilot · 2026-02-17T05:54:27Z

          -DTHUNDER_VERSION=4
          -DTHUNDER_VERSION_MAJOR=4
          -DTHUNDER_VERSION_MINOR=4
+          -DL2_TEST_OOP_RPC=ON


The L2_TEST_OOP_RPC flag is added in the first build step but appears to be missing in the documentation or other build contexts. Consider documenting why this flag is necessary for out-of-process testing or ensure it's consistently applied across all relevant build configurations.

Copilot · 2026-02-17T05:54:28Z


      - name: Generate coverage
-        if: ${{ matrix.coverage == 'with-coverage' && !env.ACT }}
+        if: ${{ matrix.coverage == 'with-coverage' }}


The condition removed && !env.ACT which was previously used to skip coverage generation in local ACT testing environments. Removing this condition means coverage will now be generated in ACT environments, which may not be intended and could cause issues in local development workflows.

Suggested change

if: ${{ matrix.coverage == 'with-coverage' }}

if: ${{ matrix.coverage == 'with-coverage' && !env.ACT }}

Copilot · 2026-02-17T05:54:28Z

+## System Architecture
+- **Plugin Structure:**
+  - The plugin is implemented in C++ and follows the WPEFramework plugin interface conventions.
+  - The main entry point is the `plugin/` directory, containing all source, header, and configuration files for the usersettings plugin.


The documentation references plugin/ as the main directory, but this is inconsistent with the typical RDK plugin naming convention (e.g., 'UserSettings'). This should be clarified to explain why the generic 'plugin' name was chosen or updated to match the actual directory structure.

Copilot · 2026-02-17T05:54:28Z

 # @global-owner1 and @global-owner2 will be requested for
 # review when someone opens a pull request.
-*       @rdkcentral/rdke_ghec_entinfra_maintainer
+*       @rdkcentral/entservices-maintainers


The code owner team reference should be verified to ensure @rdkcentral/entservices-maintainers exists and has the appropriate permissions in the GitHub organization. This change affects who receives review requests for all files in the repository.

Copilot

Pull request overview

Copilot reviewed 124 out of 528 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-17T12:17:56Z

-          ref: develop
+          repository: rdkcentral/entservices-usersettings
+          path: entservices-usersettings
+          ref: RDKEMW-13483-usersettings


The workflow is checking out from a feature branch (RDKEMW-13483-usersettings) instead of a stable branch like develop or main. This creates a dependency on a temporary branch that may be deleted after the PR is merged. Update the ref to use develop or make it configurable via workflow inputs to avoid CI failures after the feature branch is removed. Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation

Copilot · 2026-02-17T12:17:57Z

+      - name: Checkout entservices-persistentstore
+        if: ${{ inputs.caller_source == 'local' }}
+        uses: actions/checkout@v3
+        with:
+          path: entservices-persistentstore    



A new checkout step for entservices-persistentstore has been added, but there is no corresponding build or usage of this dependency in the workflow. If PersistentStore is required for testing UserSettings, document this dependency relationship in ARCHITECTURE.md or remove the checkout if it's not actually used. Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation

Suggested change

- name: Checkout entservices-persistentstore

if: ${{ inputs.caller_source == 'local' }}

uses: actions/checkout@v3

with:

path: entservices-persistentstore

Copilot

Pull request overview

Copilot reviewed 118 out of 528 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-17T13:20:48Z

-          ref: develop
+          repository: rdkcentral/entservices-usersettings
+          path: entservices-usersettings
+          ref: RDKEMW-13483-usersettings


The workflow references a specific branch name 'RDKEMW-13483-usersettings' instead of a standard branch like 'develop' or 'main'. This hardcoded branch reference should be updated to reference the default branch to ensure the workflow continues to work after this PR is merged and the feature branch is deleted.

Suggested change

ref: RDKEMW-13483-usersettings

nnaveen979 added 3 commits February 13, 2026 14:16

entservices-usersettings repo split

7485493

L1, L2 tests yaml cleanup

c00bf1e

L2-test-oop yaml file cleanup

54cbc4e

Copilot AI review requested due to automatic review settings February 13, 2026 11:17

Copilot started reviewing on behalf of agampa263 February 13, 2026 11:18 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

nnaveen979 added 2 commits February 16, 2026 16:23

revert the helpers/UtilsFile.h removed earlier

ef741cd

usersettings plugin repo cleanup done

90fadbf

Copilot AI review requested due to automatic review settings February 16, 2026 12:34

Copilot AI reviewed Feb 16, 2026

View reviewed changes

nnaveen979 added 2 commits February 16, 2026 18:20

added subdirectory based on PLUGIN enable/disable

b9a4ebb

removed unnecessary files

5048442

Copilot AI review requested due to automatic review settings February 16, 2026 13:38

Copilot AI reviewed Feb 16, 2026

View reviewed changes

nnaveen979 added 2 commits February 17, 2026 07:21

cleanup done

7935e89

modified the cmake files

06a0849

Copilot AI review requested due to automatic review settings February 17, 2026 03:08

Copilot AI reviewed Feb 17, 2026

View reviewed changes

nnaveen979 added 2 commits February 17, 2026 09:25

edited test workflows

196b259

uncommented some compiler options

4095b7f

Copilot AI review requested due to automatic review settings February 17, 2026 05:53

Copilot AI reviewed Feb 17, 2026

View reviewed changes

nnaveen979 added 2 commits February 17, 2026 17:14

workflows .yml files edited

41a3330

L2 test workflow file modified

567b9ab

Copilot AI review requested due to automatic review settings February 17, 2026 12:16

Copilot AI reviewed Feb 17, 2026

View reviewed changes

nnaveen979 added 2 commits February 17, 2026 18:23

L1, L2 test workflows edited

d830e23

plugin name corrected

6f692c6

Copilot AI review requested due to automatic review settings February 17, 2026 13:19

Copilot AI reviewed Feb 17, 2026

View reviewed changes

	Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API QueryInterfaceByCallsign() exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-usersettings/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )
	Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API QueryInterfaceByCallsign() exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-infra/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )

	add_subdirectory(plugin)
	set(PLUGIN_USERSETTINGS_DIR "plugin")
	add_subdirectory(${PLUGIN_USERSETTINGS_DIR})

	if: ${{ matrix.coverage == 'with-coverage' }}
	if: ${{ matrix.coverage == 'with-coverage' && !env.ACT }}

Conversation

agampa263 commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment