Skip to content

RDKEMW-12937: Test PR to validate workflow#10

Open
balav08 wants to merge 4 commits into
developfrom
feature/RDKEMW-12937
Open

RDKEMW-12937: Test PR to validate workflow#10
balav08 wants to merge 4 commits into
developfrom
feature/RDKEMW-12937

Conversation

@balav08
Copy link
Copy Markdown

@balav08 balav08 commented Mar 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 06:58
@balav08 balav08 requested a review from a team as a code owner March 9, 2026 06:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be a workflow-validation change for the UserSettings plugin, with no functional impact.

Changes:

  • Adds an extra blank line in UserSettingsImplementation.cpp near the include/namespace boundary.

#include <mutex>
#include "tracing/Logging.h"


Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an extra blank line between the include block and the namespace, creating a whitespace-only change and making the diff noisier. Consider keeping a single blank line here for consistency with the surrounding style.

Suggested change

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings April 15, 2026 04:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

#include <fstream>
#include "tracing/Logging.h"


Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an extra blank line between the includes and the namespace declaration, creating a whitespace-only change and slightly reducing consistency with other files in this module (which typically have a single blank line here). Consider removing the extra empty line to keep diffs clean and formatting consistent.

Suggested change

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings April 20, 2026 10:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

* limitations under the License.
*/


Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two consecutive blank lines between the license header and the first include. This appears inconsistent with nearby files (e.g., plugin/UserSettings.cpp keeps a single blank line before includes) and adds unnecessary whitespace—please drop the extra empty line.

Suggested change

Copilot uses AI. Check for mistakes.
#include <fstream>
#include "tracing/Logging.h"


Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two consecutive blank lines between the include block and the start of the namespace. To keep formatting consistent and reduce diff noise, remove the extra empty line.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants