Skip to content

GHREPOREQ-22 : Adding Headers in Missing Files#16

Open
srinibas15 wants to merge 4 commits into
developfrom
feature/GHREPOREQ-22
Open

GHREPOREQ-22 : Adding Headers in Missing Files#16
srinibas15 wants to merge 4 commits into
developfrom
feature/GHREPOREQ-22

Conversation

@srinibas15
Copy link
Copy Markdown
Contributor

Reason For Change: Adding missing headers and License
Test procedure : Compile and Verify
version: patch
Priority: P2

Copilot AI review requested due to automatic review settings March 31, 2026 07:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing Apache-2.0 file header to a test source file and updates the repository LICENSE contents.

Changes:

  • Added standard RDK Apache-2.0 license header to test_UserSettings.cpp.
  • Appended a BSD 2-Clause license block to LICENSE.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Tests/L1Tests/tests/test_UserSettings.cpp Adds the standard license/header comment at the top of the test file.
LICENSE Appends a BSD 2-Clause license section after the Apache 2.0 text.

Comment thread LICENSE
Comment on lines +202 to +227

BSD 2-Clause License

Copyright <YEAR> <COPYRIGHT OWNER>
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.

2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added BSD 2-Clause section includes placeholders (Copyright <YEAR> <COPYRIGHT OWNER>). This makes the LICENSE text incomplete/invalid and can create confusion about the project’s actual licensing. Please either remove this BSD block entirely (if the project is Apache-2.0 only) or replace the placeholders with the correct year/owner and clearly indicate why a second license applies.

Suggested change
BSD 2-Clause License
Copyright <YEAR> <COPYRIGHT OWNER>
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Copilot uses AI. Check for mistakes.
@srinibas15 srinibas15 requested a review from a team as a code owner March 31, 2026 09:09
Copilot AI review requested due to automatic review settings March 31, 2026 09:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread LICENSE
Comment on lines +207 to +208
Copyright <YEAR> <COPYRIGHT OWNER>
All rights reserved.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added BSD 2-Clause License block still contains template placeholders (Copyright <YEAR> <COPYRIGHT OWNER>), which makes the repository licensing text ambiguous. Please replace these placeholders with the actual copyright holder/year for the BSD-licensed third-party components (see NOTICE for the listed BSD-2 items) or split into separate BSD-2 sections per holder/year.

Suggested change
Copyright <YEAR> <COPYRIGHT OWNER>
All rights reserved.
Copyright for BSD-licensed components is held by their respective owners
as identified in the accompanying NOTICE file. All rights reserved.

Copilot uses AI. Check for mistakes.
@mhughesacn
Copy link
Copy Markdown

Hi All: The code matches in fossid are not significant - just matching license texts. They can be completely ignored. In any case, fossid fails are non-blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants