RDKEMW-18857 : Remove RDKCM_RDKE from all workflows#47
Open
balav08 wants to merge 1 commit into
Open
Conversation
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private. Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows. Test Procedure: refer ticket. Risks: Medium Priority: P2 version: Patch Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes usage of the RDKCM_RDKE secret across GitHub Actions workflows now that the dependent repositories are public, simplifying workflow configuration and secret management.
Changes:
- Stop passing
RDKCM_RDKEinto reusable test workflows (L1/L2/L2-OOP) and remove the correspondingworkflow_callsecret requirement. - Remove
RDKCM_RDKEusage from the native build workflow step environment. - Update component release cloning to no longer embed
RDKCM_RDKEin the clone URL.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/tests-trigger.yml | Stops forwarding RDKCM_RDKE into reusable test workflows. |
| .github/workflows/native_full_build.yml | Removes RDKCM_RDKE-backed GITHUB_TOKEN env override for the build step. |
| .github/workflows/L2-tests.yml | Drops workflow_call required secret RDKCM_RDKE. |
| .github/workflows/L2-tests-oop.yml | Drops workflow_call required secret RDKCM_RDKE. |
| .github/workflows/L1-tests.yml | Drops workflow_call required secret RDKCM_RDKE and removes a leftover commented token reference. |
| .github/workflows/component-release.yml | Removes tokenized clone URL (but still performs pushes later in the workflow). |
| run: | | ||
| set -e | ||
| git clone https://x-access-token:${{ secrets.RDKCM_RDKE }}@github.com/${{ github.repository }} project | ||
| git clone https://github.com/${{ github.repository }} project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private.
Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows.
Test Procedure: refer ticket.
Risks: Medium
Priority: P2
version: Patch