Remove two deprecated APIs#416
Open
vladimir-rangelov wants to merge 5 commits into
Open
Conversation
Contributor
|
Please provide a description in this PR as to why these are being removed (for historical purposes). There are some schemas here that we can probably clean up now that the methods are gone: These could be removed but I'm hesitant to do so right now as they seem useful: |
Contributor
Author
|
Yes, I removed the unused schemas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both APIs are bidirectional compatible, but the API signatures are slightly different, which is an API breaking change, and this is the reason for their removal.
Here is the change -
unidirectional:
function entityInfo(data)
function purchasedContent(data)
bidirectional:
function entityInfo(entityId, assedId)
function purchasedContent(offeringType, programType)