Cut releasemain

.github/copilot-instructions.md

@@ -0,0 +1,84 @@
+# firebolt-cpp-client Copilot Instructions
+
+Scope: This file applies to the firebolt-cpp-client repository.
+
+## Primary goals
+
+- Preserve API contract correctness across interface, implementation, tests, and OpenRPC fixtures.
+- Keep generated surfaces and bespoke conventions aligned.
+- Prefer minimal, targeted changes.
+
+## High-signal workflow
+
+1. For API-facing changes, update all of the following in one pass:
+   - `include/firebolt/*.h`
+   - `src/*_impl.h` and `src/*_impl.cpp`
+   - `test/unit/*Test.cpp` and `test/component/*Test.cpp`
+   - `docs/openrpc/the-spec/firebolt-open-rpc.json` when component tests depend on fixture shape.
+2. Run component tests after edits.
+3. If behavior is generator-owned, patch generator code in sibling repo and regenerate module artifacts.
+
+## Test commands
+
+- Local one-shot (current preferred):
+  - `./run-component-tests-local.sh`
+  - `./run-component-tests-local.sh --skip-image-build`
+- Legacy wrappers may still exist in conversation history; prefer the local script in this repo.
+- Unit-only:
+  - `./run-unit-tests.sh`
+
+## Actions module rules (important)
+
+- `Actions.intent` is getter-only:
+  - takes no parameters
+  - returns `Result<std::string>`
+- `Actions.onIntent` callback payload is a string value.
+- Component event trigger for `Actions.onIntent` should use a string JSON payload (for example `"launch"`), not an object.
+
+## Generated-code conventions that must be preserved
+
+- `*Impl` classes should delete copy constructor and copy assignment:
+  - `ClassName(const ClassName&) = delete;`
+  - `ClassName& operator=(const ClassName&) = delete;`
+- Unless explicitly justified as safe, `*Impl` classes should also delete move operations:
+  - `ClassName(ClassName&&) = delete;`
+  - `ClassName& operator=(ClassName&&) = delete;`
+- Keep include hygiene strict:
+  - include `<utility>` when using `std::move`
+  - remove unused includes such as `<regex>` when not used
+- Keep test names in consistent CamelCase for filtering.
+
+## Component test expectations
+
+- Red schema validation lines in logs can be expected for negative-path tests.
+- Negative tests must still verify runtime behavior (callbacks not delivered for invalid payloads), not just compile-time surface checks.
+
+## OpenRPC fixture expectations
+
+- Module descriptions must match actual API behavior.
+- Getter-style methods should carry property tags consistent with the rest of the file (for example `property:readonly` where applicable).
+- Keep notifier/subscriber metadata aligned (`x-notifier`, `x-subscriber-for`).
+
+## Regeneration notes (sibling repo)
+
+When a change is generator-owned, use `firebolt-sdk-gen` and apply module-scoped output back into this repo.
+
+Typical flow:
+
+- From `../firebolt-sdk-gen`:
+  - `./sync-plan-checklist.sh --profile core --module actions --apply --no-accessor-touchpoints --target-root ../firebolt-cpp-client`
+
+This keeps migration incremental and avoids unrelated accessor touchpoint churn.
+
+## CI parity reminders
+
+- CI uses Dockerized build/test flow and mock-firebolt integration.
+- Keep changes compatible with:
+  - `.github/workflows/ci.yml`
+  - `.github/scripts/run-component-tests.sh`
+
+## PR hygiene
+
+- If a review asks for include-file fixes, prefer precise header/source edits and re-run component tests.
+- Do not relax negative tests just to suppress red validation logs.
+- Keep commit messages scoped and explicit (example: `fix(actions): address include review comments`).

.github/workflows/ci.yml

@@ -12,9 +12,9 @@ on:
           - rpc_v2
           - legacy
   push:
-    branches: [ main, next ]
+    branches: [ main, develop,  next ]
   pull_request:
-    branches: [ main, next ]
+    branches: [ main, develop,  next ]
 
 defaults:
   run:

CHANGELOG.md

@@ -1,3 +1,13 @@
+## [0.6.0](https://github.com/rdkcentral/firebolt-cpp-client/compare/v0.5.5...v0.6.0)
+
+### Added
+- New APIs
+  - `Actions.intent` (no parameters, returns string)
+  - `Actions.onIntent` event
+
+### Changed
+- **Breaking**: `Discovery.watched` and all `Metrics.*` methods now return `Result<void>` (previously `Result<bool>`)
+
 ## [0.5.5](https://github.com/rdkcentral/firebolt-cpp-client/compare/v0.5.4...v0.5.5)
 
 ### Changed

README.md

@@ -6,3 +6,27 @@ Implementation of Firebolt C++ Client.
 For usage instructions of the API test application, see:
 
 - [test/api_test_app/README.md](test/api_test_app/README.md)
+
+## Test Runner
+
+Use `run-all-test.sh` to build and run unit/component tests locally.
+
+Examples:
+
+- `./run-all-test.sh`
+- `./run-unit-tests.sh --unit-filter "ActionsUTest.*"`
+- `./run-component-tests.sh --component-filter "*Localization*"`
+
+For the device websocket tunnel, use `setup-device-tunnel.sh`.
+Before running it, export `DEVICE_SSH_USER`, `DEVICE_SSH_HOST`, and `DEVICE_SSH_PORT`.
+
+## Lint
+
+Use `lint.sh` to run local static analysis for C/C++ sources.
+
+Examples:
+
+- `./lint.sh`
+- `./lint.sh --tidy-only`
+- `./lint.sh --tidy-only --fix`
+- `./lint.sh --cppcheck-only`

build.sh

@@ -51,8 +51,21 @@ while [[ ! -z $1 ]]; do
   esac; shift
 done
 
-[[ ! -z $SYSROOT_PATH ]] || { echo "SYSROOT_PATH not set" >/dev/stderr; exit 1; }
-[[ -e $SYSROOT_PATH ]] || { echo "SYSROOT_PATH not exist ($SYSROOT_PATH)" >/dev/stderr; exit 1; }
+if [[ -n "$SYSROOT_PATH" ]]; then
+  [[ -e "$SYSROOT_PATH" ]] || { echo "SYSROOT_PATH not exist ($SYSROOT_PATH)" >/dev/stderr; exit 1; }
+  params+=" -DSYSROOT_PATH=$SYSROOT_PATH"
+else
+  if $do_install; then
+    echo "--install requires --sysroot to be set; refusing to install without SYSROOT_PATH" >/dev/stderr
+    exit 1
+  fi
+  echo "SYSROOT_PATH not set; building without SYSROOT_PATH override"
+fi
+
+if [[ "$do_install" == true && "$bdir" == "build" && -z "${SYSROOT_PATH:-}" ]]; then
+  echo "Refusing --install without --sysroot to avoid host install into /usr" >&2
+  exit 1
+fi
 
 $cleanFirst && rm -rf $bdir
 
@@ -61,7 +74,6 @@ if [[ ! -e "$bdir" || -n "$@" ]]; then
   command -v ccache >/dev/null 2>&1 && params+=" -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache"
   cmake -B $bdir \
     -DCMAKE_BUILD_TYPE=$buildType \
-    -DSYSROOT_PATH=$SYSROOT_PATH \
     $params \
     "$@" || exit $?
 fi

docs/openrpc/openrpc/discovery.json

@@ -61,10 +61,9 @@
         }
       ],
       "result": {
-        "name": "success",
-        "summary": "whether the call was successful or not",
+        "name": "result",
         "schema": {
-          "type": "boolean"
+          "type": "null"
         }
       },
       "examples": [
@@ -89,8 +88,8 @@
             }
           ],
           "result": {
-            "name": "success",
-            "value": true
+            "name": "result",
+            "value": null
           }
         },
         {
@@ -118,8 +117,8 @@
             }
           ],
           "result": {
-            "name": "success",
-            "value": true
+            "name": "result",
+            "value": null
           }
         }
       ]