Apply clang-format to resolve CI formatting violations#68
Merged
Conversation
swethasukumarr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies clang-format-style adjustments to address CI formatting violations across the generated Actions API surface and its associated tests.
Changes:
- Normalized brace placement and indentation for namespaces/classes in the Actions interface and implementation.
- Reordered includes to match formatting/lint expectations.
- Reformatted unit/component test code (line wrapping, blank line removal) without changing behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/unit/actionsGeneratedTest.cpp |
Reorders includes and reformats EXPECT_CALL/lambda formatting to satisfy style checks. |
test/component/actionsGeneratedTest.cpp |
Removes trailing blank line/whitespace to align with formatting rules. |
src/json_types/actions.h |
Reorders includes and normalizes namespace brace style. |
src/actions_impl.h |
Normalizes namespace/class brace placement to match formatting conventions. |
src/actions_impl.cpp |
Reformats constructor initializer list and method brace placement (no logic change). |
include/firebolt/actions.h |
Reorders includes and reformats interface braces/method formatting for consistency. |
# Conflicts: # test/unit/actionsGeneratedTest.cpp
brendanobra
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.