Update develop with latest main#69
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs changes from develop into main by aligning a few test utilities/mocks and a small runtime behavior tweak in the Metrics implementation (specifically how “no params” are represented in JSON-RPC calls).
Changes:
- Update event verification helpers to take a non-const
bool&and standardize the timeout usage withEventWaitTime. - Enhance unit-test
mockInvoke()to route invocations throughJsonEngine::MockResponse()(instead of always returning success). - Change
Metrics.ready/signIn/signOutto invoke withnlohmann::json()(null) rather than an explicit empty object initializer.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/utils.h | Adjusts event verification helper signatures to use bool&. |
| test/utils.cpp | Uses EventWaitTime consistently and matches updated helper signatures. |
| test/unit/mock_helper.h | Makes mockInvoke() validate against OpenRPC-derived JsonEngine::MockResponse(). |
| src/metrics_impl.cpp | Represents “no params” calls using nlohmann::json() for Metrics invoke methods. |
brendanobra
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.