Skip to content

RDKEMW-14899 : Add unit tests for transport layer coverage gaps #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swethasukumarr merged 10 commits into from
May 19, 2026
Merged

RDKEMW-14899 : Add unit tests for transport layer coverage gaps #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4218912
RDKEMW-14899 : Add unit tests for transport layer coverage gaps
swethasukumarr May 15, 2026
d7c5858
RDKEMW-14899 : Resolve nullptr UB in logger and address PR comments
swethasukumarr May 15, 2026
20426b1
RDKEMW-14899 : Add develop branch to CI build and test workflow
swethasukumarr May 18, 2026
31b2092
RDKEMW-14899 : Fix clang-format violations
swethasukumarr May 18, 2026
4063003
RDKEMW-14899 : Resolve Copilot review comments in unit tests
swethasukumarr May 18, 2026
21e53da
RDKEMW-14899 : Resolve Copilot review comments in unit tests
swethasukumarr May 18, 2026
dfb0966
RDKEMW-14899 : Use std::filesystem for filename extraction
swethasukumarr May 18, 2026
2f69e5d
RDKEMW-14899 : Replace hardcoded line numbers with functional descrip…
swethasukumarr May 18, 2026
9ca9fb9
RDKEMW-14899 : Fix memory leak in SubscriptionManagerUTest::Unsubscri…
swethasukumarr May 19, 2026
dfab6c0
RDKEMW-14899 : Refactor pointer identity variables to use real object…
swethasukumarr May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI Build and Test

on:
push:
branches: [ main, '+([0-9])\.+([0-9])\.x-maintenance', '+([0-9])\.+([0-9])-rc' ]
branches: [ main, develop, '+([0-9])\.+([0-9])\.x-maintenance', '+([0-9])\.+([0-9])-rc' ]
pull_request:
branches: [ main, '+([0-9])\.+([0-9])\.x-maintenance', '+([0-9])\.+([0-9])-rc' ]
branches: [ main, develop, '+([0-9])\.+([0-9])\.x-maintenance', '+([0-9])\.+([0-9])-rc' ]
Comment thread
swethasukumarr marked this conversation as resolved.
Comment thread
swethasukumarr marked this conversation as resolved.
workflow_dispatch:
inputs:
protocol:
Expand Down
11 changes: 2 additions & 9 deletions src/logger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <cstdarg>
#include <cstring>
#include <ctime>
#include <filesystem>
#include <map>
#include <stdio.h>
#include <sys/time.h>
Expand Down Expand Up @@ -120,15 +121,7 @@ void Logger::log(LogLevel logLevel, const std::string& module, const std::string
std::string fileName;
if (formatter_addLocation)
{
fileName = strrchr(file.c_str(), '/');
if (fileName.empty())
{
fileName = file;
}
else
{
fileName = fileName.substr(1);
}
fileName = std::filesystem::path(file).filename().string();
}

#pragma GCC diagnostic push
Expand Down
Loading
Loading