Add component tests to the demo SDK by vladimir-rangelov · Pull Request #287 · rdkcentral/firebolt-openrpc

vladimir-rangelov · 2026-01-22T09:10:20Z

No description provided.

Copilot

Pull request overview

This pull request adds comprehensive component testing infrastructure to the demo SDK. The changes reorganize the project structure from test_sdk to demo_sdk and introduce a new component test suite alongside existing unit tests.

Changes:

Renamed project directory from test_sdk to demo_sdk throughout package.json scripts
Added component test infrastructure with utilities for HTTP client operations and event subscription testing
Introduced TypeScript compilation step for unit tests and new test organization structure

Reviewed changes

Copilot reviewed 22 out of 36 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tsconfig.json	New TypeScript configuration for compiling unit tests
jest.config.json	Updated test regex to support .mjs files
package.json	Reorganized test scripts and updated all references from test_sdk to demo_sdk
test/suite/remove-unused-schemas.test.js	Fixed import path after directory restructure
demo_sdk/test/unit/*.test.ts	Updated import paths for relocated test files
demo_sdk/test/transpiled-suite/*.test.js	Generated JavaScript files from TypeScript unit tests
demo_sdk/test/component/*.mjs	New component tests for properties and events
demo_sdk/test/component/utils/*	New utility modules for component testing
demo_sdk/sharedSchemas/types.json	New shared type definitions
demo_sdk/schemas/types.json	Extended type definitions for the SDK
demo_sdk/openrpc/*.json	OpenRPC specification files for simple, provider, property, and event modules
demo_sdk/sdk/*	SDK configuration and index files
demo_sdk/*.js	Test harness and setup files

Comments suppressed due to low confidence (1)

demo_sdk/test/unit/simple.test.ts:50

Avoid automated semicolon insertion (93% of all statements in the enclosing script have an explicit semicolon).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-22T09:13:55Z

+        requestBasicMethod(...args) {
+            providerMethodRequestReceived = true;
+            throw {
+                message: 'An error occured!',


There is a spelling error in "occured". This should be "occurred".

Copilot · 2026-01-22T09:13:56Z

+test('Provider method throw an exeption', () => {
+    expect(providerMethodRequestReceived).toBe(true);
+    expect(providerMethodErrorSent).toBe(true);
+    expect(errorMessage).toBe('An error occured!');


There is a spelling error in "occured". This should be "occurred".

Copilot · 2026-01-22T09:13:56Z

+test('Provide method 1 called with two args', () => {
+    expect(numberOfArgsMethodOne).toBe(1);
+});
+test('Provide method 1 parame1 is true', () => {


The naming in the test description "Provide method 1 parame1 is true" contains a typo. It should be "Provide method 1 param1 is true".

Suggested change

test('Provide method 1 parame1 is true', () => {

test('Provide method 1 param1 is true', () => {

Copilot · 2026-01-22T09:13:56Z

+    "test:unit": "NODE_OPTIONS=--experimental-vm-modules npx --config=jest.config.json --detectOpenHandles jest ./test/suite",
+    "test:component": "NODE_OPTIONS=--experimental-vm-modules npx jest --runInBand ./demo_sdk/test/component",
+		"test": "npm run test:setup && npm run test:unit && NODE_OPTIONS=--experimental-vm-modules npx --config=jest.config.json --detectOpenHandles jest ./demo_sdk/test/transpiled-suite",


The test script includes a mix of npx and npm run commands with inconsistent options. The --config=jest.config.json flag should come after jest, not after npx. The correct syntax should be npx jest --config=jest.config.json rather than npx --config=jest.config.json jest.

Copilot · 2026-01-22T09:13:57Z

+    // this one is good as long as there's no errors yet
+    expect(1).toBe(1);
+});
+test('Provider method throw an exeption', () => {


There is a spelling error in "exeption". This should be "exception".

Suggested change

test('Provider method throw an exeption', () => {

test('Provider method throw an exception', () => {

Copilot · 2026-01-22T09:13:57Z

+    "test:setup": "rm -rf demo_sdk/test/transpiled-suite && npx tsc --target es6 --moduleResolution node --outDir demo_sdk/test/transpiled-suite",
+    "test:unit": "NODE_OPTIONS=--experimental-vm-modules npx --config=jest.config.json --detectOpenHandles jest ./test/suite",
+    "test:component": "NODE_OPTIONS=--experimental-vm-modules npx jest --runInBand ./demo_sdk/test/component",
+		"test": "npm run test:setup && npm run test:unit && NODE_OPTIONS=--experimental-vm-modules npx --config=jest.config.json --detectOpenHandles jest ./demo_sdk/test/transpiled-suite",


Line 16 contains inconsistent whitespace - it uses tabs instead of spaces like the rest of the file. This should use spaces for consistency with the rest of the package.json file.

Copilot · 2026-01-22T09:13:57Z

+import "./utils/bootstrap.mjs";
+
+
+import { PropertyExtension, Simple, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";


Unused import Simple.

Suggested change

import { PropertyExtension, Simple, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";

import { PropertyExtension, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";

Copilot · 2026-01-22T09:13:57Z

@@ -0,0 +1,111 @@
+import "./utils/bootstrap.mjs";
+
+import { test, expect, describe } from "@jest/globals";


Unused import describe.

Suggested change

import { test, expect, describe } from "@jest/globals";

import { test, expect } from "@jest/globals";

Copilot · 2026-01-22T09:13:58Z

+beforeAll(() => {
+    transport.onSend((json) => {
+        if (json.method) {
+            let [module, method] = json.method.split('.');


Unused variable method.

Suggested change

let [module, method] = json.method.split('.');

let [module] = json.method.split('.');

Copilot · 2026-01-22T09:13:58Z

+    }
+    transport.onSend((json) => {
+        if (json.method) {
+            let [module, method] = json.method.split('.');


Unused variable method.

Suggested change

let [module, method] = json.method.split('.');

const [module] = json.method.split('.');

vladimir-rangelov added 2 commits January 21, 2026 10:53

refactor: Convert unit tests to TypeScript

bcbddbe

test: Add component tests

9dd4744

Copilot AI review requested due to automatic review settings January 22, 2026 09:10

Copilot started reviewing on behalf of vladimir-rangelov January 22, 2026 09:10 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

tomasz-blasz approved these changes Jan 22, 2026

View reviewed changes

refactor: Fix review comments

6d7dc81

vladimir-rangelov merged commit f33a8c5 into next-bidirectional Jan 22, 2026
1 of 2 checks passed

github-actions Bot locked and limited conversation to collaborators Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add component tests to the demo SDK#287

Add component tests to the demo SDK#287
vladimir-rangelov merged 3 commits into
next-bidirectionalfrom
ci/add-component-tests

vladimir-rangelov commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	test('Provide method 1 parame1 is true', () => {
	test('Provide method 1 param1 is true', () => {

	test('Provider method throw an exeption', () => {
	test('Provider method throw an exception', () => {

		import "./utils/bootstrap.mjs";


		import { PropertyExtension, Simple, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";

	import { PropertyExtension, Simple, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";
	import { PropertyExtension, EventExtension } from "../../../build/sdk/javascript/src/sdk.mjs";

		@@ -0,0 +1,111 @@
		import "./utils/bootstrap.mjs";

		import { test, expect, describe } from "@jest/globals";

	import { test, expect, describe } from "@jest/globals";
	import { test, expect } from "@jest/globals";

	let [module, method] = json.method.split('.');
	let [module] = json.method.split('.');

	let [module, method] = json.method.split('.');
	const [module] = json.method.split('.');

Conversation

vladimir-rangelov commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants