Events argument name not printed in the generated documentation#289
Merged
vladimir-rangelov merged 1 commit intoJan 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where event/callback argument names were not being printed in generated documentation for JavaScript. The fix adds the result name to callback parameter signatures, ensuring they include both the parameter name and type (e.g., value: string) instead of just the type.
Changes:
- Updated the JavaScript result-callback template to include the parameter name along with the type
- Modified the
getMethodSignatureResultfunction to replace both the name and type placeholders in templates
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| languages/javascript/templates/result-callback/default.ts | Added ${method.result.name}: prefix to include the argument name in callback signatures |
| src/macrofier/types.mjs | Added replacement for ${method.result.name} placeholder to populate the template with the actual result name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasz-blasz
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.