Feature/factory impl#57
Draft
IshvarKR wants to merge 3 commits into
Draft
Conversation
Code changes Code changes Code changes Update in Makefile.am
Base class and Derived class changes DriverImpl changes and hdmicecstatus enum changes changed the return type of base class to int
vinodtel
requested review from
Kishoredarmaradje,
Ranjeetha07,
Sid2001-maker,
anand-ky,
apatel859 and
vinodtel
apatel859
reviewed
Jun 2, 2026
| class HDMICecHalFactory { | ||
| public: | ||
| static std::unique_ptr<HDMICecHal> Create(); | ||
| static bool isAidlServiceAvailable(); |
Contributor
There was a problem hiding this comment.
This is internal API so u can remove from here
apatel859
reviewed
Jun 2, 2026
| { | ||
| CCEC_LOG(LOG_INFO, "HDMICecHalFactory::isAidlServiceAvailable invoked\r\n"); | ||
|
|
||
| const char *env = std::getenv("HDMICEC_USE_AIDL_HAL"); |
Contributor
There was a problem hiding this comment.
if you can make IServiceManager binder call here then no need to export env variable and have check in .service file
apatel859
requested changes
Jun 2, 2026
Contributor
apatel859
left a comment
apatel859
left a comment
There was a problem hiding this comment.
Can you cimpile this code in normal build and vdevice build and see if you face any compilation issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.