Skip to content

TEST#117

Open
yuvaramachandran-gurusamy wants to merge 8 commits into
developfrom
topic/RDKEMW-11076_Test
Open

TEST#117
yuvaramachandran-gurusamy wants to merge 8 commits into
developfrom
topic/RDKEMW-11076_Test

Conversation

@yuvaramachandran-gurusamy
Copy link
Copy Markdown
Contributor

@yuvaramachandran-gurusamy yuvaramachandran-gurusamy commented Dec 1, 2025

No description provided.

@yuvaramachandran-gurusamy
RDKEMW-11076: libdssrv API directly used for audioport configuration
c43b788 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Apply suggestions from code review
474ba28 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix Copilot review comments
ae11fe5 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner December 1, 2025 18:27
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix for cov_build error
e67beeb 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix for ds stubs linker errors
63b9f38 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix ds_stubs build error
2a691b5 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix for ds stubs linker error
7c3e605 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Dec 1, 2025 •
edited
Loading

Coverity Issue - Unchecked return value

Calling "IARM_Bus_RegisterCall" without checking return value (as is done elsewhere 14 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
dsmgr/dsMgrPwrEventListener.c:138

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Dec 1, 2025 •
edited
Loading

Coverity Issue - Unchecked return value

Calling "IARM_Bus_RegisterCall" without checking return value (as is done elsewhere 14 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
dsmgr/dsMgrPwrEventListener.c:139

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Dec 1, 2025 •
edited
Loading

Coverity Issue - Unchecked return value

Calling "IARM_Bus_RegisterCall" without checking return value (as is done elsewhere 14 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
dsmgr/dsMgrPwrEventListener.c:140

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Dec 1, 2025 •
edited
Loading

Coverity Issue - Unchecked return value

Calling "IARM_Bus_RegisterCall" without checking return value (as is done elsewhere 14 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
dsmgr/dsMgrPwrEventListener.c:141

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Dec 1, 2025

Coverity Issue - Unchecked return value

Calling "IARM_Bus_RegisterCall" without checking return value (as is done elsewhere 14 out of 14 times).

Medium Impact, CWE-252
CHECKED_RETURN

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
dsmgr/dsMgrPwrEventListener.c:142

rdkcmf-jenkins
rdkcmf-jenkins reviewed Dec 1, 2025
View reviewed changes
Comment thread dsmgr/dsMgrPwrEventListener.c
for (size_t i = 0; i < videoPorts.size(); i++)
try
{
bool doEnable = get_video_port_standby_setting(videoPorts.at(i).getName().c_str());
Copy link
Copy Markdown
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "videoPorts.size()" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Comment thread dsmgr/dsMgrPwrEventListener.c
{
// Disable the Audio Port
device::AudioOutputPort aPort = aPorts.at(i);
INT_INFO("[%s] Disabling Audio PortName [%s] at [%d] for powerState [%d] \r\n",__FUNCTION__, aPort.getName().c_str(), i, powerState);
Copy link
Copy Markdown
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "aPorts.size()" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Comment thread dsmgr/dsMgrPwrEventListener.c
try
{
device::VideoOutputPort vPort = videoPorts.at(i);
// Enable the Video Port
Copy link
Copy Markdown
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "videoPorts.size()" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Comment thread dsmgr/dsMgrPwrEventListener.c
{
device::AudioOutputPort aPort = aPorts.at(i);
bool isEnablePersist = aPort.getEnablePersist();
INT_INFO("[%s] Audio PortName[%s] isEnablePersist[%d] at [%d] \r\n", __FUNCTION__, aPort.getName().c_str(), isEnablePersist, i);
Copy link
Copy Markdown
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Invalid type in argument to printf format specifier

Argument "aPorts.size()" to format specifier "%d" was expected to have type "int" but has type "unsigned long".

Medium Impact, CWE-686
PRINTF_ARGS

Comment thread stubs/ds_stubs.cpp

VideoOutputPortType::VideoOutputPortType(const int id) {
(void)id;
}
Copy link
Copy Markdown
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Uninitialized scalar field

Non-static class member "_restrictedResolution" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Comment thread stubs/ds_stubs.cpp Outdated
@yuvaramachandran-gurusamy
RDKEMW-11076: Fix for Coverity issue
dd87f03 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins Awaiting requested review from rdkcmf-jenkins

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvaramachandran-gurusamy @rdkcmf-jenkins