Revert "RDKEMW-15033 : Move tenablehdcp to rdke GitHub"#193
Open
santoshcomcast wants to merge 1 commit into
Open
Revert "RDKEMW-15033 : Move tenablehdcp to rdke GitHub"#193santoshcomcast wants to merge 1 commit into
santoshcomcast wants to merge 1 commit into
Conversation
This reverts commit 15b97fc.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts an earlier dsMgr startup change that had introduced STB-specific HDCP initialization via MFR at boot, apparently to help isolate an MFR-related crash. In practice, it removes the startup HDCP bootstrap path from dsMgr and rolls back the related stub/logging changes.
Changes:
- Remove the STB-only async HDCP enable flow from
DSMgr_Start(), including the MFR/HDCP helper thread and related includes/declarations. - Drop the
_dsEnableHDCPstub entry point that was only added to support that startup path. - Revert the
rdkProfiledebug messages to the older formatting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
dsmgr/dsMgr.c |
Reverts the STB startup path that read HDCP data from MFR and enabled HDCP asynchronously during dsMgr initialization. |
stubs/dshalsrv_stubs.c |
Removes the no-op _dsEnableHDCP stub that supported the reverted dsMgr flow. |
utils/rdkProfile.c |
Reverts the debug log formatting for detected RDK_PROFILE values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -472,15 +335,6 @@ IARM_Result_t DSMgr_Start() | |||
| INT_INFO("Set resolution during dsMgr init .. \r\n"); | |||
| _SetVideoPortResolution(); | |||
| setupPlatformConfig(); | |||
Comment on lines
+139
to
+144
| INT_DEBUG("[%s]: Found RDK_PROFILE is TV", __FUNCTION__); | ||
| } | ||
| else if (0 == strncmp(rdkProfile, PROFILE_STR_STB, strlen(PROFILE_STR_STB))) | ||
| { | ||
| ret = PROFILE_STB; | ||
| INT_DEBUG("[%s]: Found RDK_PROFILE is STB \n", __FUNCTION__); | ||
| INT_DEBUG("[%s]: Found RDK_PROFILE is STB", __FUNCTION__); |
| @@ -472,15 +335,6 @@ IARM_Result_t DSMgr_Start() | |||
| INT_INFO("Set resolution during dsMgr init .. \r\n"); | |||
| _SetVideoPortResolution(); | |||
| setupPlatformConfig(); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #177 to check MFR crash