Reason for change: Fix for Client IPv4 address display when#72
Open
sethumcacit-bot wants to merge 2 commits into
Open
Reason for change: Fix for Client IPv4 address display when#72sethumcacit-bot wants to merge 2 commits into
sethumcacit-bot wants to merge 2 commits into
Conversation
LAN DHCP is Disable Test Procedure: Build and Verify Priority: P1 Risks: low
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates LAN Manager host state handling to remove a client's IPv4 address from the host table when LAN DHCP is disabled for supported product builds.
Changes:
- Adds product-gated syscfg checks for device mode and DHCP server state.
- Clears host IPv4 address state when DHCP is disabled.
- Skips lease/range validation after IPv4 state is removed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+723
to
+729
| CcspTraceWarning(("<%s> devicemode: %s\n",_FUNCTION__, device_mode)); | ||
| if(strncmp(device_mode, "business", strlen("business")) == 0) | ||
| { | ||
| #endif | ||
| if(!syscfg_get( NULL, "dhcp_server_enabled", dhcp_server_enabled, sizeof(dhcp_server_enabled))) | ||
| { | ||
| CcspTraceWarning(("<%s> dhcp_server_enabled: %s\n",_FUNCTION__, dhcp_server_enabled)); |
|
|
||
| if(pHost->ipv4Active == TRUE) { | ||
| if (state) { | ||
| CcspTraceWarning(("<%s> Debug trace for XB10-2559 \n",__FUNCTION__)); |
Comment on lines
+714
to
+719
| CcspTraceWarning(("<%s> Debug trace for XB10-2559 \n",__FUNCTION__)); | ||
| #if defined (_CBR_PRODUCT_REQ_) || defined (_ONESTACK_PRODUCT_REQ_) | ||
| char device_mode[32] = {0}; | ||
| char dhcp_server_enabled[32] = {0}; | ||
|
|
||
| CcspTraceWarning(("<%s> _ONESTACK_PRODUCT_REQ_ \n",__FUNCTION__)); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sethumcacit-bot
force-pushed
the
topic/XB10-2559_Fix
branch
from
1958703 to
c17a38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAN DHCP is Disable
Test Procedure: Build and Verify
Priority: P1
Risks: low