RDKEMW-19268 Bring VPLAY-12884 to 8.4#119
Open
sayanurag wants to merge 1 commit into
Open
Conversation
Reason for change: On processing a gst HDCP error, flush with teardown is called without stopping stream injection leading to an abort Test Procedure: See ticket Risks: low Signed-off-by: Anurag Krishnan <akrish513@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the middleware IPK feed configuration to consume artifacts from a different artifact path/tag (intended to bring the VPLAY-12884 fix into the 8.4 integration by pointing builds at a specific middleware artifact set).
Changes:
- Switches middleware and OSS middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/.... - Replaces the version-style
RELEASE_NUMvalue with a ticket ID (RDKEMW-19268) for artifact path construction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the default artifact tag (RELEASE_NUM) and switches the middleware feed path to middleware-dbg/.... |
| conf/machine/include/oss_mw.inc | Switches the OSS middleware feed path to middleware-dbg/.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
11
| RELEASE_NUM = "RDKEMW-19268" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: On processing a gst HDCP error, flush with teardown is called without stopping stream injection leading to an abort
Test Procedure: See ticket
Risks: low