Conversation
Reason for the change: Upgrading systemd PREFERRED version to 1:250 Risk : Low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is titled as a systemd preferred-version upgrade to v250, but the actual changes in this diff adjust the middleware IPK feed paths to hardcoded debug/staging locations.
Changes:
- Updated
MW_IPK_PATHto point to a hardcodedmiddleware-dbg/sysd250_mwfeed path. - Updated
MW_OSS_IPK_PATHto point to a hardcodedmiddleware-dbg/sysd250_Renfeed path.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the main middleware IPK feed path to a hardcoded debug location. |
| conf/machine/include/oss_mw.inc | Changes the OSS middleware IPK feed path to a hardcoded debug location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8
to
11
| RELEASE_NUM = "8.6.2.0" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/sysd250_mw" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" |
Comment on lines
5
to
6
| MW_OSS_IPK_PATH ?= "middleware-dbg/sysd250_Ren" | ||
| MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}" |
Reason for the change: Upgrading systemd PREFERRED version to 1:250 Risk : Low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change: Upgrading systemd PREFERRED version to 1:250
Risk : Low